cli icon indicating copy to clipboard operation
cli copied to clipboard

Improve golden file generation functionality

Open piyush-garg opened this issue 4 years ago • 5 comments

Right now when we hit make generated it generates golden files for test scenarios and also updates the already existent files for test scenarios. But if there is some name change in the test name, it generates a new golden file, and the old one becomes redundant and remains there forever.

This function should be improved to remove all golden files and generate new ones so that we don't end with redundant golden files.

piyush-garg avatar Sep 14 '20 14:09 piyush-garg

/assign @vdemeester

As you are already working on it and see a PR also

piyush-garg avatar Oct 22 '20 11:10 piyush-garg

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jan 20 '21 12:01 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Feb 19 '21 13:02 tekton-robot

/lifecycle frozen

vdemeester avatar May 03 '21 14:05 vdemeester

@piyush-garg , would like to contribute if not done already

binkkatal avatar Apr 29 '22 11:04 binkkatal