chains icon indicating copy to clipboard operation
chains copied to clipboard
verified publisher icon tektoncd

Full access to image url and digest in StorageOpts

Open chuangw6 opened this issue 3 years ago • 7 comments

Changes

Related to https://github.com/tektoncd/chains/issues/476

Prior, the StorageOpts key for OCI artifact was the first 12 characters of the digest.

Now, we set it to be the full representation of the OCI artifact in the format of IMAGE_URL@IMAGE_DIGEST so that storage backends can have the full access to the identifier of the OCI artifact directly.

Signed-off-by: Chuang Wang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs included if any changes are user facing
  • [ ] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

StorageOpts have the full access to the image identifier.

chuangw6 avatar Oct 04 '22 20:10 chuangw6

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Oct 04 '22 20:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/grafeas/grafeas.go 79.3% 78.8% -0.6

tekton-robot avatar Oct 04 '22 21:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/grafeas/grafeas.go 79.3% 78.8% -0.6

tekton-robot avatar Oct 04 '22 21:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 68.9% 64.0% -5.0
pkg/chains/storage/grafeas/grafeas.go 79.3% 78.8% -0.6

tekton-robot avatar Oct 05 '22 22:10 tekton-robot

/retest

chuangw6 avatar Oct 05 '22 22:10 chuangw6

/retest

chuangw6 avatar Oct 17 '22 15:10 chuangw6

/assign @wlynch

chuangw6 avatar Oct 17 '22 15:10 chuangw6

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 68.9% 64.0% -5.0
pkg/chains/storage/grafeas/grafeas.go 79.3% 78.8% -0.6

tekton-robot avatar Oct 17 '22 20:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 68.9% 64.0% -5.0
pkg/chains/storage/grafeas/grafeas.go 79.3% 78.8% -0.6

tekton-robot avatar Oct 18 '22 17:10 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Oct 18 '22 18:10 tekton-robot