tektoncd
feat(oci): support insecure OCI registry
Changes
- Add support for connecting to insecure OCI registries with self-signed certificates
- Refactor remote options building into a dedicated method
- Add comprehensive test coverage for both secure and insecure modes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [ ] Meets the Tekton contributor standards (including functionality, content, code)
- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
feat(oci): add complete insecure OCI registry support with security warnings
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/storage/oci/legacy.go | 40.0% | 44.5% | 4.5 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/storage/oci/legacy.go | 40.0% | 44.5% | 4.5 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/storage/oci/legacy.go | 40.0% | 44.5% | 4.5 |
@waveywaves I’ve adjusted the code based on your suggestions. Please take a look when you have a moment. ❤️
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/storage/oci/legacy.go | 40.0% | 45.4% | 5.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/storage/oci/legacy.go | 40.0% | 45.4% | 5.4 |
| pkg/chains/storage/oci/simple.go | 83.3% | 86.7% | 3.3 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/storage/oci/legacy.go | 40.0% | 45.4% | 5.4 |
| pkg/chains/storage/oci/simple.go | 83.3% | 86.7% | 3.3 |
@l-qing really appreciate the extra test coverage 🤗 I will take a look at this PR soon
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: waveywaves
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment