chains icon indicating copy to clipboard operation
chains copied to clipboard

Sign other types of artifacts

Open priyawadhwa opened this issue 4 years ago • 11 comments
trafficstars

Right now we only sign TaskRuns and OCI Images, but it would be cool to give users a way to sign other types of results (binaries, files, whatever)

priyawadhwa avatar Jun 18 '21 18:06 priyawadhwa

Two that immediately come to mind are PipelineRuns as well as Runs (for custom tasks cc @imjasonh).

It might also be prudent to better formalize the way image outputs are signed. I was spitballing this with @dlorenc a week or so ago, but this would be another great application of duck typing task/pipeline[1] input/output shapes (as I was playing with in mattmoor/mink motivated by CLI DevX).

[1] - From here on I'm going to say "task" when I really mean task, pipeline, or a user-defined custom task definition.

The general idea is that tooling (including some possible defined by Tekton upstream) would standardize around certain task signature "shapes". Imagine if tasks with outputs named like dev.tekton.imagedigest.* (strawman) could be interpreted as being image digest outputs?

These duck types aren't semantically meaningful to tekton/pipeline itself (like say pipeline resources were), but enable an extensibility model that puts the burden of adhering to such conventions on consuming tools (e.g. tkn, dashboard, chains).

Another aspect of wanting standardization of certain conventions is that we can start to make the catalog adhere to them so that folks can get a really nice OOTB experience.

mattmoor avatar Jul 12 '21 16:07 mattmoor

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Oct 15 '21 17:10 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 14 '21 17:11 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 14 '21 18:12 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Dec 14 '21 18:12 tekton-robot

/reopen /remove-lifecycle rotten

priyawadhwa avatar Dec 14 '21 18:12 priyawadhwa

@priyawadhwa: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Dec 14 '21 18:12 tekton-robot

/area s3c

xchapter7x avatar Mar 04 '22 16:03 xchapter7x

TEP-84 is related to signing of PipelineRuns.

lcarva avatar Mar 24 '22 18:03 lcarva

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jun 22 '22 18:06 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jul 22 '22 19:07 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 21 '22 19:08 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 21 '22 19:08 tekton-robot

I think this might be being covered by the TEP-0109 structured results work by @ywluogg ?

/reopen

bobcatfish avatar Nov 30 '22 17:11 bobcatfish

@bobcatfish: Reopened this issue.

In response to this:

I think this might be being covered by the TEP-0109 structured results work by @ywluogg ?

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Nov 30 '22 17:11 tekton-robot

Yeah I think if the binaries and the files captured in Intoto attestation can be signed by TEP 109

ywluogg avatar Nov 30 '22 18:11 ywluogg

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 30 '22 18:12 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Dec 30 '22 18:12 tekton-robot

For anyone looking for this functionality, the place it is currently documented is https://github.com/tektoncd/chains/blob/main/docs/intoto.md#structured-result-type-hinting

bobcatfish avatar Jan 10 '23 17:01 bobcatfish