Support multinamespace informer filtering
Changes
Support of specifying a list of namespaces to restrict the informer. You can provide a list of namespaces as an argument to the controller, and it will only watch objects (PipelineRuns and TaskRuns) within these specified namespaces. If no list is provided, the controller will default to watching all namespaces.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
The Chains controller now supports specifying a list of namespaces to restrict the informer.
You can provide a list of namespaces as an argument to the controller, and it will only watch objects (PipelineRuns and TaskRuns) within these specified namespaces.
If no list is provided, the controller will default to watching all namespaces.
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 2.6% | |
| pkg/reconciler/filter.go | Do not exist | 3.8% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 1.3% | |
| pkg/reconciler/filter.go | Do not exist | 7.7% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 2.6% | |
| pkg/reconciler/filter.go | Do not exist | 3.8% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 86.4% | 87.0% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 88.9% | 89.5% | 0.6 |
/test pull-tekton-chains-integration-tests
/test pull-tekton-chains-integration-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 82.1% | 82.8% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 83.3% | 84.0% | 0.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 82.1% | 82.8% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 83.3% | 84.0% | 0.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 82.1% | 82.8% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 83.3% | 84.0% | 0.7 |
/lgtm
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/filter.go | Do not exist | 100.0% | |
| pkg/reconciler/pipelinerun/controller.go | 82.1% | 82.8% | 0.6 |
| pkg/reconciler/taskrun/controller.go | 83.3% | 84.0% | 0.7 |
@wlynch, I believe your comments have been addressed. Could you have another look?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lcarva, wlynch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lcarva,wlynch]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment