chains icon indicating copy to clipboard operation
chains copied to clipboard

Support multinamespace informer filtering

Open jkhelil opened this issue 1 year ago • 11 comments

Changes

Support of specifying a list of namespaces to restrict the informer. You can provide a list of namespaces as an argument to the controller, and it will only watch objects (PipelineRuns and TaskRuns) within these specified namespaces. If no list is provided, the controller will default to watching all namespaces.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The Chains controller now supports specifying a list of namespaces to restrict the informer. 
You can provide a list of namespaces as an argument to the controller, and it will only watch objects (PipelineRuns and TaskRuns) within these specified namespaces. 
If no list is provided, the controller will default to watching all namespaces.

jkhelil avatar Jul 01 '24 11:07 jkhelil

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 0.0%

tekton-robot avatar Jul 01 '24 11:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 2.6%
pkg/reconciler/filter.go Do not exist 3.8%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 01 '24 11:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 1.3%
pkg/reconciler/filter.go Do not exist 7.7%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 01 '24 12:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 2.6%
pkg/reconciler/filter.go Do not exist 3.8%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 02 '24 09:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 02 '24 10:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 02 '24 11:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 02 '24 11:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 02 '24 12:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 02 '24 12:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 03 '24 06:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%

tekton-robot avatar Jul 05 '24 08:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 05 '24 08:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6

tekton-robot avatar Jul 05 '24 08:07 tekton-robot

/test pull-tekton-chains-integration-tests

PuneetPunamiya avatar Jul 09 '24 09:07 PuneetPunamiya

/test pull-tekton-chains-integration-tests

PuneetPunamiya avatar Jul 11 '24 06:07 PuneetPunamiya

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 82.1% 82.8% 0.6
pkg/reconciler/taskrun/controller.go 83.3% 84.0% 0.7

tekton-robot avatar Jul 22 '24 07:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 82.1% 82.8% 0.6
pkg/reconciler/taskrun/controller.go 83.3% 84.0% 0.7

tekton-robot avatar Jul 22 '24 08:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 82.1% 82.8% 0.6
pkg/reconciler/taskrun/controller.go 83.3% 84.0% 0.7

tekton-robot avatar Jul 23 '24 06:07 tekton-robot

/lgtm

lcarva avatar Jul 24 '24 14:07 lcarva

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 82.1% 82.8% 0.6
pkg/reconciler/taskrun/controller.go 83.3% 84.0% 0.7

tekton-robot avatar Jul 24 '24 14:07 tekton-robot

@wlynch, I believe your comments have been addressed. Could you have another look?

lcarva avatar Jul 24 '24 14:07 lcarva

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 29 '24 14:07 tekton-robot