chains
chains copied to clipboard
tektoncd
PipelineRuns with v2alpha4 to process StepActions
This new version will now process the information from any associated StepAction from the executed PipelineRun.
Also, the way chains read results from PipelineRuns to populate the subjects field is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the new isBuildArtifact property in the value.
Refactors to share logic between v2alph3 and v2alpha4.
NOTE: this PR depends on https://github.com/tektoncd/chains/pull/1111, so it will show extra changes that should disappear once we merge #1111 and we rebase this one.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs included if any changes are user facing
- [ ] Has Tests included if any functionality added or changed
- [ ] Follows the commit message standard
- [ ] Meets the Tekton contributor standards (including functionality, content, code)
- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
NONE
Hi @renzodavid9. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/formats/slsa/internal/build_definition/build_definition.go | 80.0% | 77.8% | -2.2 |
| pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go | 87.9% | 85.7% | -2.2 |
| pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go | 78.5% | 81.2% | 2.8 |
| pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go | Do not exist | 59.3% | |
| pkg/chains/formats/slsa/v2alpha4/slsav2.go | 85.7% | 75.0% | -10.7 |
| pkg/chains/objects/objects.go | 25.6% | 23.9% | -1.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/formats/slsa/internal/build_definition/build_definition.go | 80.0% | 77.8% | -2.2 |
| pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go | 87.9% | 85.7% | -2.2 |
| pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go | 78.5% | 81.2% | 2.8 |
| pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go | Do not exist | 59.3% | |
| pkg/chains/formats/slsa/v2alpha4/slsav2.go | 85.7% | 75.0% | -10.7 |
| pkg/chains/objects/objects.go | 25.6% | 23.8% | -1.8 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/chains/formats/slsa/internal/build_definition/build_definition.go | 80.0% | 77.8% | -2.2 |
| pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go | 87.9% | 85.7% | -2.2 |
| pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go | 78.5% | 81.2% | 2.8 |
| pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go | Do not exist | 59.3% | |
| pkg/chains/formats/slsa/v2alpha4/slsav2.go | 85.7% | 75.0% | -10.7 |
| pkg/chains/objects/objects.go | 25.6% | 23.8% | -1.8 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
Thanks for the cleanup Renzo!
Happy to approve after fixing the linter error.
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chitrangpatel
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [chitrangpatel]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment