chains
chains copied to clipboard
tektoncd
Add new v2alpha4 version for TaskRuns
This new version will now process the information from any associated StepAction from the executed TaskRun.
Also, the way chains read results from TaskRun to populate the subjects field is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the new isBuildArtifact property in the value
NOTE: Updating the Tekton version used in e2e tests to enable StepActions is breaking the Rekor behavior. A tracking issue was opened in https://github.com/tektoncd/chains/issues/1117. After we solve that issue we would be able to add back the integration test with StepActions. We evaluated to do the test using the GitHub actions but we don't have an easy way to target an specific e2e test to not run in all the matrix of Pipeline releases. Also looks like GitHub tests are only testing one case.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
NONE
Hi @renzodavid9. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/artifacts/signable.go | 70.6% | 74.2% | 3.6 |
| pkg/chains/formats/format.go | Do not exist | 20.0% | |
| pkg/chains/formats/format.go | Do not exist | 50.0% | |
| pkg/chains/formats/format.go | Do not exist | 20.0% | |
| pkg/chains/formats/format.go | Do not exist | 20.0% | |
| pkg/chains/formats/format.go | Do not exist | 13.3% | |
| pkg/chains/formats/slsa/extract/extract.go | 62.3% | 66.2% | 3.9 |
| pkg/chains/formats/slsa/internal/material/material.go | 92.3% | 92.9% | 0.6 |
| pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go | 87.6% | 87.9% | 0.3 |
| pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go | Do not exist | 84.3% | |
| pkg/chains/formats/slsa/v2alpha4/slsav2.go | Do not exist | 85.7% | |
| pkg/chains/objects/objects.go | 32.7% | 31.2% | -1.5 |
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
/lgtm
Will fix the linter issues caused by deprecated intoto-golang structs and functions in a followup PR
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report