catlin icon indicating copy to clipboard operation
catlin copied to clipboard
verified publisher icon tektoncd

Adding v1 ApiVersioning compatibility for catlins pre-commit hooks

Open arifash01 opened this issue 1 year ago • 10 comments

Running catlin pre-commit hooks on yaml files with apiVersion v1 and kind task failed. This is a minimal fix that adds some support for v1 and maintains support to v1beta1. Issue: https://github.com/tektoncd/catlin/issues/10

arifash01 avatar Mar 15 '24 15:03 arifash01

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: arifash01 / name: Arif Ashogbon (3b43dfddccad5be947ea36c9e2e505758c722301)

linux-foundation-easycla[bot] avatar Mar 15 '24 15:03 linux-foundation-easycla[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign piyush-garg after the PR has been reviewed. You can assign the PR to them by writing /assign @piyush-garg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Mar 15 '24 15:03 tekton-robot

Hi @arifash01. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Mar 15 '24 15:03 tekton-robot

@arifash01 Please sign the cla.

khrm avatar Mar 15 '24 18:03 khrm

The following is the coverage report on the affected files. Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

tekton-robot avatar Mar 15 '24 18:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

tekton-robot avatar Mar 18 '24 14:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

tekton-robot avatar Mar 18 '24 14:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

tekton-robot avatar Mar 18 '24 15:03 tekton-robot

@arifash01 Please sign the cla.

done

arifash01 avatar Mar 19 '24 18:03 arifash01