catalog icon indicating copy to clipboard operation
catalog copied to clipboard

buildah 0.8

Open jimmyjones2 opened this issue 8 months ago • 6 comments

  • Don't use interpolation (move to env)
  • Easier way of specifying build args - previously would have to use BUILD_EXTRA_ARGS and quote them very carefully
  • Add warning for BUILD_EXTRA_ARGS and PUSH_EXTRA_ARGS that inputs need to be sanitized

e.g. now the following are correctly passed as Dockerfile build arguments:

        - name: BUILD_ARGS
          value:
            - |
                foo=b\"a'z"u uu
            - baz=8888$(echo foo)ssss`ssss` -v a:b

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Follows the authoring recommendations
  • [x] Includes docs (if user facing)
  • [x] Includes tests (for new tasks or changed functionality)
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [] Commit messages follow commit message best practices
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • [ ] File path follows <kind>/<name>/<version>/name.yaml

    • [ ] Has README.md at <kind>/<name>/<version>/README.md

    • [ ] Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • [ ] Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • [ ] mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

jimmyjones2 avatar Jun 22 '24 18:06 jimmyjones2