catalog icon indicating copy to clipboard operation
catalog copied to clipboard

Fix catalog test for ppc64le

Open Sachin-Itagi opened this issue 1 year ago • 13 comments

Changes

Replaces the GRADLE_IMAGE parameter for gradle/0.4 to the multi-arch alternative. Currently the image is x86 only.

Added an Extra MAVEN_IMAGE parameter which is missing for the maven-0-3 test via linux-ppc64le.sh script.

Added a patch command to enable Step Actions on the cluster. This is needed for stepaction test.

Added a patch command to disable Affinity Assistant on the cluster. This allow binding of two PVCs at the same time and is needed by the maven-0-3 test.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Follows the authoring recommendations
  • [ ] Includes docs (if user facing)
  • [ ] Includes tests (for new tasks or changed functionality)
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Commit messages follow commit message best practices
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • [ ] File path follows <kind>/<name>/<version>/name.yaml

    • [ ] Has README.md at <kind>/<name>/<version>/README.md

    • [ ] Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • [ ] Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • [ ] mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

Sachin-Itagi avatar May 03 '24 09:05 Sachin-Itagi

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Sachin-Itagi / name: Sachin Itagi (144de9f1320408ffd6d439ded693c8cf06f378e9)

Hi @Sachin-Itagi. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar May 03 '24 09:05 tekton-robot

@vdemeester @bobcatfish Can you please review this PR which fixes the catalog test for Power.

Sachin-Itagi avatar May 03 '24 11:05 Sachin-Itagi

Should this bump the task version to 0.5?

AlanGreene avatar May 03 '24 15:05 AlanGreene

@afrittoli could you please review this PR ?

valen-mascarenhas14 avatar May 09 '24 09:05 valen-mascarenhas14

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar May 10 '24 17:05 tekton-robot

/test pull-tekton-catalog-integration-tests

Sachin-Itagi avatar May 13 '24 05:05 Sachin-Itagi

/test pull-tekton-catalog-integration-tests

Sachin-Itagi avatar May 14 '24 03:05 Sachin-Itagi

/test pull-tekton-catalog-integration-tests

Sachin-Itagi avatar May 14 '24 04:05 Sachin-Itagi

/test pull-tekton-catalog-integration-tests

Sachin-Itagi avatar May 14 '24 10:05 Sachin-Itagi

New changes are detected. LGTM label has been removed.

tekton-robot avatar May 14 '24 12:05 tekton-robot

/retest

vdemeester avatar May 15 '24 12:05 vdemeester

/test pull-tekton-catalog-integration-tests

Sachin-Itagi avatar May 22 '24 07:05 Sachin-Itagi

@Sachin-Itagi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-catalog-integration-tests 2734c661b4ec7768c36e272d5fb27b3bf172b925 link true /test pull-tekton-catalog-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar May 22 '24 08:05 tekton-robot

@vinamra28 @vdemeester Any suggestions on resolving the failure observed during the pull-tekton-catalog-integration-tests Job. The changes that have been made don't seem to be the cause of this issue and It doesn't seem to be a flaky issue as well.

It seems to be an issue with PIP. Could not fetch URL https://pypi.python.org/simple/pip/: There was a problem confirming the ssl certificate: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852) - skipping

Any help to resolve this issue and merge the PR would be appreciated. Thanks.

Sachin-Itagi avatar May 23 '24 03:05 Sachin-Itagi

@Sachin-Itagi, this task should get fixed in https://github.com/tektoncd/catalog/pull/1266

vinamra28 avatar May 27 '24 16:05 vinamra28

/test pull-tekton-catalog-integration-tests

Sachin-Itagi avatar May 31 '24 03:05 Sachin-Itagi

/lgtm

vinamra28 avatar May 31 '24 04:05 vinamra28