catalog
catalog copied to clipboard
remove deprecated go get method in latest golang image
go get is deprecated, so we need to use go install method to download.
Changes
go get is deprecated in latest golang docker image, so we need use go install method
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [ ] Follows the authoring recommendations
- [ ] Includes docs (if user facing)
- [ ] Includes tests (for new tasks or changed functionality)
- See the end-to-end testing documentation for guidance and CI details.
- [ ] Meets the Tekton contributor standards (including functionality, content, code)
- [ ] Commit messages follow commit message best practices
- [ ] Has a kind label. You can add one by adding a comment on this PR that
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [ ] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
-
[ ] File path follows
<kind>/<name>/<version>/name.yaml
-
[ ] Has
README.md
at<kind>/<name>/<version>/README.md
-
[ ] Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resource -
[ ] Has mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
-
[ ] mandatory
spec.description
follows the convention``` spec: description: >- one line summary of the resource Paragraph(s) to describe the resource. ```
-
See the contribution guide for more details.
/kind misc
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dibyom, vinamra28
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~task/golang-fuzz/OWNERS~~ [vinamra28]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/test pull-catalog-catlin-lint
@AlanGreene: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-catalog-build-tests
-
/test pull-tekton-catalog-integration-tests
-
/test pull-tekton-catalog-unit-tests
Use /test all
to run all jobs.
In response to this:
/test pull-catalog-catlin-lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Catlin Output
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:
In golang-fuzz-fuzz line 8:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" ${FLAGS}
^------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" "${FLAGS}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
/test pull-catalog-catlin-lint
@vinamra28: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-catalog-build-tests
-
/test pull-tekton-catalog-integration-tests
-
/test pull-tekton-catalog-unit-tests
Use /test all
to run all jobs.
In response to this:
/test pull-catalog-catlin-lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Catlin Output
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:
In golang-fuzz-fuzz line 8:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" ${FLAGS}
^------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" "${FLAGS}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
/retest
/test pull-catalog-catlin-lint
@vinamra28: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-catalog-build-tests
-
/test pull-tekton-catalog-integration-tests
-
/test pull-tekton-catalog-unit-tests
Use /test all
to run all jobs.
In response to this:
/test pull-catalog-catlin-lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Catlin Output
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:
In golang-fuzz-fuzz line 8:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" ${FLAGS}
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" "${FLAGS}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
@Basavaraju-G will you be able to fix the catlin o/p?
@Basavaraju-G will you be able to fix the catlin o/p?
Sure.
/test pull-catalog-catlin-lint
@Basavaraju-G: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-catalog-build-tests
-
/test pull-tekton-catalog-integration-tests
-
/test pull-tekton-catalog-unit-tests
Use /test all
to run all jobs.
In response to this:
/test pull-catalog-catlin-lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Catlin Output
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:
In golang-fuzz-fuzz line 8:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" ${FLAGS}
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
"${GOPATH}"/bin/gotip test -fuzz="${TARGET}" "${FLAGS}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
/test pull-catalog-catlin-lint
@vinamra28: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-catalog-build-tests
-
/test pull-tekton-catalog-integration-tests
-
/test pull-tekton-catalog-unit-tests
Use /test all
to run all jobs.
In response to this:
/test pull-catalog-catlin-lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Catlin Output
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
@Basavaraju-G: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-tekton-catalog-integration-tests | 0a8d02af0e82e1e38c2e8e7f2f85a093a51819c7 | link | unknown | /test pull-tekton-catalog-integration-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@Basavaraju-G, can you please rebase your PR once? I guess some other tests are affecting the PR merge