catalog icon indicating copy to clipboard operation
catalog copied to clipboard

Fixing maven/0.3 test fail due to more that one PVC is bound

Open kabhiibm opened this issue 2 years ago • 5 comments

Changes

An extra PVC resource has been added in the workspace of new test cases maven/0.3. It's Taskrun is failing due to more than one PVC with message: "more than one PersistentVolumeClaim is bound" We found that this is a known issue and found few Pipelines issue links with this discussion: Issue#3480, Issue#3085, Issue#2979 /kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Follows the authoring recommendations
  • [ ] Includes docs (if user facing)
  • [ ] Includes tests (for new tasks or changed functionality)
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Commit messages follow commit message best practices
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • [ ] File path follows <kind>/<name>/<version>/name.yaml

    • [ ] Has README.md at <kind>/<name>/<version>/README.md

    • [ ] Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • [ ] Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • [ ] mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

kabhiibm avatar Aug 03 '23 08:08 kabhiibm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign bobcatfish after the PR has been reviewed. You can assign the PR to them by writing /assign @bobcatfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 03 '23 08:08 tekton-robot

Hi @kabhiibm. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 03 '23 08:08 tekton-robot

Catlin Output
FILE: task/maven/0.3/maven.yaml
HINT : Task: tekton.dev/v1beta1 - name: "maven" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "mvn-settings" references "$(params.PROXY_HOST)" directly from its script block. For reliability and security, consider putting the param into an environment variable of the Step and accessing that environment variable in your script instead.
WARN : Step "mvn-goals" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation

tekton-robot avatar Aug 03 '23 08:08 tekton-robot

/assign @vdemeester @bobcatfish

kabhiibm avatar Aug 21 '23 07:08 kabhiibm

Hey @kabhiibm,

There is a few things :

  • It should work, without affinity assistant (this should be documented)
  • The Task doesn't specify to mount a PVC for the local-repo, so technically, it's not on the task itself
  • Even if we agreed on removing this optional workspace, it would need to be in a new version as this would break current users.

But, I don't think we need to fix this, as I don't really this it as something to be fixed.

vdemeester avatar Aug 21 '23 09:08 vdemeester