git-clone: 0.8 -> 0.9, bumping git-init image

[vdemeester]

Changes

This bumps the git-init image to 0.40.0 instead of 0.29.0.

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• [x] Follows the authoring recommendations
• [x] Includes docs (if user facing)
• [x] Includes tests (for new tasks or changed functionality)
  • See the end-to-end testing documentation for guidance and CI details.
• [x] Meets the Tekton contributor standards (including functionality, content, code)
• [x] Commit messages follow commit message best practices
• [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [x] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation

  • [x] File path follows <kind>/<name>/<version>/name.yaml

  • [x] Has README.md at <kind>/<name>/<version>/README.md

  • [x] Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • [x] Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • [x] mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide for more details.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

Diff between version 0.8 and 0.9

diff --git a/task/git-clone/0.8/git-clone.yaml b/task/git-clone/0.9/git-clone.yaml
index 6b17769..f371b65 100644
--- a/task/git-clone/0.8/git-clone.yaml
+++ b/task/git-clone/0.9/git-clone.yaml
@@ -5,7 +5,7 @@ metadata:
   labels:
     app.kubernetes.io/version: "0.8"
   annotations:
-    tekton.dev/pipelines.minVersion: "0.29.0"
+    tekton.dev/pipelines.minVersion: "0.38.0"
     tekton.dev/categories: Git
     tekton.dev/tags: git
     tekton.dev/displayName: "git clone"
@@ -102,7 +102,7 @@ spec:
     - name: gitInitImage
       description: The image providing the git-init binary that this Task runs.
       type: string
-      default: "gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.29.0"
+      default: "gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.40.0"
     - name: userHome
       description: |
         Absolute path to the user's home directory.

[tekton-robot]

Catlin Output

FILE: task/git-clone/0.9/git-clone.yaml
ERROR: Resource path is invalid; expected path: task/git-clone/0.8/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation

[tekton-robot]

@vdemeester: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-catalog-integration-tests	ff9268130de94650f38261754e9bfcba37bab794	link	true	/test pull-tekton-catalog-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chmouel]

weird error that seems relevant,

it's been so long that it wasnt update that nobody noticed therre was new features needed to be updated in relation with git-init binary changes 😅

[chmouel]

spare checkout works when launching directly so not sure what is it

% ./bin/git-init '-url=https://github.com/kelseyhightower/nocode' '-revision=' '-refspec=' '-path=/tmp/output/' '-sslVerify=true' '-submodules=true' '-depth=1' '-sparseCheckoutDirectories=CONTRIBUTING.md,STYLE.md' -terminationMessagePath=/tmp/foobar
{"level":"info","ts":1663671691.9207299,"caller":"git/git.go:176","msg":"Successfully cloned https://github.com/kelseyhightower/nocode @ 6c073b08f7987018cbb2cb9a5747c84913b3608e (grafted, HEAD) in path /tmp/output/"}
{"level":"info","ts":1663671691.9672074,"caller":"git/git.go:215","msg":"Successfully initialized and updated submodules in path /tmp/output/"}

[vinamra28]

@vdemeester any updates on this? 😅

[tekton-robot]

@vdemeester: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

Closing as https://github.com/tektoncd/catalog/pull/1092 has been merged.