catalog icon indicating copy to clipboard operation
catalog copied to clipboard

Cleanup and enhance pull_request_template.

Open bendory opened this issue 2 years ago • 3 comments

Changes

  • Move all link definitions down to the bottom for readability.
  • Added request for kind label
  • Added link to end-to-end testing documentation

/kind documentation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:


bendory avatar Aug 09 '22 11:08 bendory

/assign @chmouel

/assign @imjasonh

I got assigned to 2 people on parental leave. :-(

bendory avatar Aug 09 '22 11:08 bendory

/retest-required

bendory avatar Aug 09 '22 23:08 bendory

/lgtm

dibyom avatar Aug 15 '22 19:08 dibyom

Looks good to me, but I'll leave it to the @tektoncd/catalog-maintainers to approve.

afrittoli avatar Aug 15 '22 20:08 afrittoli

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 16 '22 02:08 tekton-robot

/lgtm /retest

piyush-garg avatar Aug 16 '22 05:08 piyush-garg

/retest-required

bendory avatar Aug 16 '22 15:08 bendory

/test pull-tekton-catalog-integration-tests

bendory avatar Aug 16 '22 16:08 bendory

/retest-required

bendory avatar Aug 16 '22 17:08 bendory

/retest-required

bendory avatar Aug 16 '22 22:08 bendory

/retest

vinamra28 avatar Aug 17 '22 04:08 vinamra28

@bendory, can you please rebase your PR over upstream main branch? (This will unblock your PR)

vinamra28 avatar Aug 17 '22 04:08 vinamra28