Alec Delaney
Alec Delaney
I think it's worth keeping open until tested, unless you know the change that fixed, as I don't (unless it was some weird packaging thing I fixed and that's why...
I also agree - between the lack of additional reports and the fact that it does seem like everything is being packaged correctly, I think this is all set!
You got it!
Technically this is still valid - the idea was to use duck typing, but I don't believe that is implemented (or decided otherwise).
This seems to be the only Learn Guide that would require changes: https://learn.adafruit.com/adafruit-drv2605-haptic-controller-breakout?view=all
@kattni I really like `isort` and think it's worth adding here and patching to the libraries. I don't think it will mess with the `try`/`except` block we using for type...
If I recall correctly, isort typically doesn't conflict with black or pylint. The only one that I'm not fully sure about is `ungrouped-imports`, but off the top of my head...
@jepler Awesome, thank you!! That's totally patchable. Can you provide that list of repos that will need manual patching? I have a tool that will catch repos that fail the...
I'm happy with this, and would be willing to help patch up things if we merge this. @jepler, if you want to merge and regenerate that list, I'll happily take...
Nice! I have a couple of comments: - I think conditional statements would be good. I could see this become an issue if people push single commits, and it breaks...