obsidian-gpgCrypt icon indicating copy to clipboard operation
obsidian-gpgCrypt copied to clipboard

Permanently asks for "Please enter the password for decryption"

Open knarxy opened this issue 1 year ago • 1 comments

Permanently asks for "decryption password", on opening every single file, even after entering the private key master password prior.

Had it set to GnuPG CLI Wrapper and use a local key. Set password timeout to 86400 seconds (equals one day). - Still permanent popups from qt-pinentry "Enter your decryption password".

Maybe someone is able to reproduce the error, so we can help pin it down?

Thanks y'all, due to this bug I sadly have to stop using the plugin for now. It even show the popup when opening files, that aren't encrypted at all...

Image of error message is attached, even though it is in german. Translated to english the text means something like "Please enter the password for decryption"

Screenshot 2024-07-17 063530

knarxy avatar Jul 17 '24 04:07 knarxy

Hi @knarxy Thanks a lot for raising this issue. Obisidan made some changes of how they are reading files which leads to multipe asynchronous executions of the same (file read) functions. Unfortunately, this causes some issues in gpgCrypt and I'm still looking for a solution to fix this.

But I never saw the popup for unencrypted files. Can you double check this and maybe provide a way to reproduce this on my end? That would be very helpful.

tejado avatar Jul 17 '24 18:07 tejado

Hi, I had very probably related issue, at least some symptoms are the same and caused by multiple modal dialogs asking to enter passphrase. It is annoying to close other dialogs after entering passphrase in the first one, but even worse - if left open without entering passphrase for loooong time, it eventually slows computer from all the endless open modal dialogs.

Got annoyed enough to create solution that works for me - now only one modal dialog is created, no matter what. Can create pull request or explain solution for you to replicate - whichever you prefer.

vits avatar Jan 03 '25 20:01 vits

@vits Thanks so much - Im using the extension myself and getting annoyed as well. But unfortunately I havent much time in the last months to take care about it. This will change soon, so to improve the addon. I would love to see your solution - appreciate a PR.

tejado avatar Jan 04 '25 09:01 tejado

@tejado you should be able to recreate this, if you choose GnuPG CLI as backend

knarxy avatar Jan 09 '25 21:01 knarxy

@tejado you should be able to recreate this, if you choose GnuPG CLI as backend

What exactly are you now refering to? Im using the GnuPG CLI backend but never get any prompt for unencrypted files, if you talking about this.

I will release a new version with few bug fixes soon.

tejado avatar Jan 10 '25 08:01 tejado

Solved via PR #27 and releases with v0.3.0

tejado avatar Jan 15 '25 18:01 tejado

@vits I added you to the README.md credits. I hope this is okay for you.

tejado avatar Jan 16 '25 09:01 tejado

@vits I added you to the README.md credits. I hope this is okay for you.

@tejado Sure, thanks.

vits avatar Jan 16 '25 20:01 vits