obsidian-gpgCrypt icon indicating copy to clipboard operation
obsidian-gpgCrypt copied to clipboard

Cache option "Remember passphrase?" should be disabled when using WRAPPER backend

Open robigan opened this issue 1 year ago • 3 comments

https://github.com/tejado/obsidian-gpgCrypt/blob/003aef79d3f2f9079a0ca27172e2adaee9763949/src/settings/SettingsTab.ts#L247-L266

The option to cache the passphrase should be disabled when using a Wrapper implementation, regardless of if this project wishes to cache it or not, this should be handled by an agent and is generally WAY safer.

robigan avatar Jun 12 '24 11:06 robigan

I should say that the project can do whatever it wants, but I don't see code in main.ts for its usage when using wrapper backend. It's a pointless option when wrapper is used.

robigan avatar Jun 12 '24 11:06 robigan

Hey @robigan With the current version you are correct: it has no function. But it was intentional as I wanted to add a symmetric encryption mode handled only over OpenPGP.js. I'm not sure yet if I will introduce this so it might make sense to disable it in the meantime for the gpg CLI wrapper.

tejado avatar Jun 12 '24 20:06 tejado

Hey @robigan With the current version you are correct: it has no function. But it was intentional as I wanted to add a symmetric encryption mode handled only over OpenPGP.js. I'm not sure yet if I will introduce this so it might make sense to disable it in the meantime for the gpg CLI wrapper.

Ahh I see what you mean. Why handled only by OpenPGP.js? Can't GPG do the same?

robigan avatar Jun 12 '24 20:06 robigan

Solved via PR #27 and releases with v0.3.0

tejado avatar Jan 15 '25 18:01 tejado