Gabriel Nelle

Results 39 comments of Gabriel Nelle

Note: having the same issue with mockery `v2.12.2`

What was the intention of that logic? In what use case is a file given instead of a URL? EDIT: for whoever looks at this, it'd be the key question...

@tzach: can you plan this in to be checked?

@tzach Happy new year 🥳! Can I draw your attention to this once more? Currently we are using this change with a `go.mod` replace statement. That is not ideal especially...

@tzach: on the last scylla conference you said, that PRs are always welcome. Seeing all the PRs here waiting for months without any attention paints a very different picture. 😞...

@zimnx thx for the review. I applied the requested changes :)

Note: adding `t.Parallel()` to the sub-test in `batchx_test.go` will close the session before the sub-test is done (`defer session.Close()` executes too early). EDIT: adjusted to use `t.Cleanup` instead of `defer`.

@zimnx Thanks! Adjusted 😄

The issue seems to be linked to complex types. With base types it seems to be working (tested with int). But when the only difference is an `int` wrapped into...

It is also an issue if calls to a method are dependent on a map iteration, since the map iteration is randomised. By default the order should not matter (as...