OpenPoGoWeb icon indicating copy to clipboard operation
OpenPoGoWeb copied to clipboard

Make it possible to disable Pokemon Go map style from config

Open BobbyWibowo opened this issue 8 years ago • 8 comments

This will disable Pokemon Go map style only when explicitly instructed to

BobbyWibowo avatar Jul 31 '16 10:07 BobbyWibowo

Cool! This is only on initial load? I tried to make it a setting you can just flip on in the settings but i have an issue.. When the map gets re-drawn it seems all the items and the trainer are gone (These need to be saved somewhere in a var i assume, since new items will appear on the map) You can checkout my code here

RolfKoenders avatar Jul 31 '16 20:07 RolfKoenders

@RolfKoenders Yeah, it's only on initial load. Just a simple configurable setting since someone requested for it. As for more advanced stuff, I had actually made a switch style setting in my personal build: https://github.com/BobbyWibowo/OpenPoGoWeb/commit/e4d1d449205de0d54cac0d035e87f4746b5cb99e#commitcomment-18463528.

Basically, you shouldn't redraw the map. But instead, just pass the new style setting to the existing map. The map object has a function called setOptions() which allows you to pass new options. So I simply did setOptions(style: [le' new style]), and it would change the styling without breaking anything else.

BobbyWibowo avatar Aug 01 '16 04:08 BobbyWibowo

status on this?

MaxLeiter avatar Aug 08 '16 17:08 MaxLeiter

@MaxLeiter Should work just fine as it is imo

BobbyWibowo avatar Aug 08 '16 17:08 BobbyWibowo

conflicts

Reaver01 avatar Aug 11 '16 05:08 Reaver01

I've been using this for a week and a half. Aside from the merge conflicts, it works great.

knowncitizen avatar Aug 11 '16 15:08 knowncitizen

@Reaver01 I'm not sure if I did it right, but I guess conflicts are fixed now.

BobbyWibowo avatar Aug 11 '16 15:08 BobbyWibowo

👍

Approved with PullApprove

Reaver01 avatar Aug 12 '16 05:08 Reaver01