xsdata icon indicating copy to clipboard operation
xsdata copied to clipboard

Allow to keep SimpleTypes

Open untereiner opened this issue 1 year ago • 2 comments

📒 Description

Allow to keep simpleTypes via the Config file

Resolves #692

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

untereiner avatar Feb 07 '24 15:02 untereiner

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 07 '24 16:02 sonarqubecloud[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a1e5502) 100.00% compared to head (8bd754c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         8768      8775    +7     
  Branches      2082      2084    +2     
=========================================
+ Hits          8768      8775    +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 07 '24 16:02 codecov[bot]

@tefra Am I on a good track by modifying config settings to introduce the simpleTypes to keep ?

untereiner avatar Mar 08 '24 14:03 untereiner

@tefra Am I on a good track by modifying config settings to introduce the simpleTypes to keep ?

@untereiner yes

tefra avatar Mar 08 '24 14:03 tefra

Please reopen when you are ready

tefra avatar Mar 09 '24 18:03 tefra

@tefra I am not able to go further. I don't understand where the simpleTypes are catched and where I could filter them. Could you help me, or point me where I have to look ?

  • I think it is in one of the handlers of the FLATTEN step.
  • Also reset_attribute_type and copy_attribute_properties have similar behavior

untereiner avatar Mar 12 '24 08:03 untereiner

Please take a look at this branch, it's not complete, 74 tests fail in w3c-test-suite but it should give you some idea on how to proceed.

https://github.com/tefra/xsdata/tree/generate-simple-types

I am afraid I have other priorities to finish this one and I won't accept contributions that break the w3c-test-suite

tefra avatar Mar 25 '24 16:03 tefra