teeworlds-translation icon indicating copy to clipboard operation
teeworlds-translation copied to clipboard

Some strings are missing for translation

Open ArionWT opened this issue 6 years ago • 7 comments

Hello, There aren't some strings for translation on Transifex:

Server
body
marking
decoration
hands
feet
eyes

(screenshots on Imgur)

If you add them to the .json file manually, translated strings works in the game (at least in version 0.7.2). Maybe this is some kind of bug in some convert script for loading on Transifex?

ArionWT avatar Feb 08 '19 23:02 ArionWT

Forwarded to https://github.com/teeworlds/teeworlds/issues/2027 since this is a code issue

Dune-jr avatar Feb 08 '19 23:02 Dune-jr

Fixed by https://github.com/teeworlds/teeworlds/pull/2029, updated Transifex

Dune-jr avatar Feb 09 '19 18:02 Dune-jr

Seems other two strings don't work in the new menu: All in src\game\client\components\menus.cpp:2532 Favorites in src\game\client\components\menus.cpp:2530 They are in .json file, but not applied ingame. _2019-02-10_00-06-49

ArionWT avatar Feb 09 '19 21:02 ArionWT

Those are filters defined in ui_settings.json. Since filters can be customized by the user (but not really those), it would be difficult to localize them.

@oy should we change that somehow and localize the default filter names, or leave it as is?

Dune-jr avatar Feb 09 '19 23:02 Dune-jr

@Dune-jr yeah, we could localize them.

oy avatar Feb 10 '19 10:02 oy

Hello, Missed one string on Transifex: Menu background transparency

And string №336 You have to wait %1.f seconds to change identity. on Transifex may be You have to wait %1.0f seconds to change identity. due this commit.

ArionWT avatar Mar 29 '19 11:03 ArionWT

Yeah, need to update Transifex for the menu background transparency. The second thing isn't a big deal, I can automate a fix.

Dune-jr avatar Mar 29 '19 12:03 Dune-jr