grunt-protractor-runner icon indicating copy to clipboard operation
grunt-protractor-runner copied to clipboard

Issue: directConnect option not passed in correctly.

Open wawyed opened this issue 10 years ago • 2 comments
trafficstars

directConnect option support was added in this commit.

https://github.com/rubenv/grunt-protractor-runner/commit/86d2f917b7e4f4c32dd0a5baeb9ddc8ea7033dd4

Although, the commit added the option as a string, even though in the protractor docs: https://github.com/angular/protractor/blob/master/docs/referenceConf.js, the option is specified as boolean, so no matter what you set that option is always evaluated to true ( since any non empty string is true ).

wawyed avatar Feb 06 '15 14:02 wawyed

It's even worse: the current code for reading of parameters prevents any parameter from having the value false:

if (a in opts.args || grunt.option(a)) {
    // this will never happen for options which have a `false` value
    args.push('--'+a, grunt.option(a) || opts.args[a]);
}

sonata82 avatar May 08 '15 13:05 sonata82

Thats true.

directConnect: false results to Error: browserName (phantomjs) is not supported with directConnect.

readme42 avatar Sep 30 '15 10:09 readme42