teemtee
Add maximum size limit validation for ReportPortal log uploads
As pointed by user in :https://github.com/teemtee/tmt/issues/4273#issuecomment-3483326367, we should set a maximum size limit validation for ReportPortal log uploads.
Pull Request Checklist
- [x] implement the feature
- [ ] write the documentation
- [x] extend the test coverage
- [ ] update the specification
- [ ] adjust plugin docstring
- [ ] modify the json schema
- [ ] mention the version
- [x] include a release note
LGTM, just a minor request.
Also can you explain why does the user set
(log|traceback)_size_limit?
Because sometimes some teams/individuals have no use for 32 MB of reports, and it makes their use of Reportportal terrible experience.
LGTM, just a minor request. Also can you explain why does the user set
(log|traceback)_size_limit?Because sometimes some teams/individuals have no use for 32 MB of reports, and it makes their use of Reportportal terrible experience.
Ah it's not the max log that they allow themselves to send, but rather how far back in the log do they want to cut off the logs that they save? Makes sense.
Please do not use fixes together with an issue comment. That may accidentally close the issue. Use something like relates to. Could also use more context in the description
Please do not use fixes together with an issue comment. That may accidentally close the issue. Use something like relates to. Could also use more context in the description
sure, updated:)
The pull request checklist is not complete. @skycastlelily, could you please remove irrelevant items and complete what's missing? I think this change definitely deserves a release note.
The pull request checklist is not complete. @skycastlelily, could you please remove irrelevant items and complete what's missing? I think this change definitely deserves a release note.
Addressed: https://github.com/teemtee/tmt/pull/4300/commits/5b5758b0d8f6bb6f773f2fddbf3c3d3168e3b35c :)