tmt icon indicating copy to clipboard operation
tmt copied to clipboard

Simplify parsing of HW requirements and add missing ones

Open happz opened this issue 1 year ago • 4 comments

It turned out some requirements were left out and nothing was parsing them. The "maximal" unit test was incorrect and did not report this.

The patch

  • adds parsing for missing requirement groups (gpu, device),
  • several individual requirements were also missing,
  • simplifies parsing of groups of constraints, providing helpers to avoid repetition,
  • and fixes the test guarding this.

Pull Request Checklist

  • [x] implement the feature
  • [x] extend the test coverage

happz avatar May 13 '24 11:05 happz

Blocked on https://github.com/teemtee/tmt/pull/2924

happz avatar May 13 '24 11:05 happz

@happz thank for an update! Would you consider adding requirement group "device" as described in https://tmt.readthedocs.io/en/stable/spec/hardware.html#device ? In some cases like Driver Update Program we do not classify devices as gpu/network/etc but need to find systems by device's ID only

juk avatar May 15 '24 15:05 juk

@happz thank for an update! Would you consider adding requirement group "device" as described in https://tmt.readthedocs.io/en/stable/spec/hardware.html#device ? In some cases like Driver Update Program we do not classify devices as gpu/network/etc but need to find systems by device's ID only

device should be one of the refactored and completed requirements, see https://github.com/teemtee/tmt/pull/2928/files#diff-1f37ee00a19e467a4f192fb6c06f6f3cce3b9e460896ed5397a89054bf58d085R1371

Note that this patch focuses on shared library part of HW requirements - the implementation for Beaker provisioning will follow soon.

happz avatar May 15 '24 16:05 happz

device should be one of the refactored and completed requirements, see https://github.com/teemtee/tmt/pull/2928/files#diff-1f37ee00a19e467a4f192fb6c06f6f3cce3b9e460896ed5397a89054bf58d085R1371

Oh sorry, missed it. Thank you!

juk avatar May 15 '24 20:05 juk

Unrelated failures -> merging.

happz avatar Jun 11 '24 11:06 happz