teemtee
Pass correct spec to _parse_system
I already checked before I submitted this merge request^^,we are good there, as labcontroller is Not a subtab of system,while numanodes is.
On Mon, May 13, 2024 at 3:06 PM Miloš Prchlík @.***> wrote:
@.**** commented on this pull request.
In tmt/hardware.py https://github.com/teemtee/tmt/pull/2924#discussion_r1597974156:
@@ -1335,7 +1335,7 @@ def _parse_generic_spec(spec: Spec) -> BaseConstraint: group.constraints += [_parse_location(spec)]
if 'system' in spec:
group.constraints += [_parse_system(spec)]
group.constraints += [_parse_system(spec['system'])]Could you include a fix for location as well? Check line 1335, it suffers from the same issue :(
— Reply to this email directly, view it on GitHub https://github.com/teemtee/tmt/pull/2924#pullrequestreview-2051860282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFR23EE7YSMVQMNWAO7WKTZCBRAJAVCNFSM6AAAAABHTLQOMOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJRHA3DAMRYGI . You are receiving this because you authored the thread.Message ID: @.***>
I already checked before I submitted this merge request^^,we are good there, as labcontroller is Not a subtab of system,while numanodes is.
True, but it's the same bug, it needs to be spec['location'] rather than spec. I made the same mistake when I added location parsing, would be nice to fix two instances of the same bug in one patch.
ah,right,not sure what was I thinking😅
On Mon, May 13, 2024 at 3:34 PM Miloš Prchlík @.***> wrote:
I already checked before I submitted this merge request^^,we are good there, as labcontroller is Not a subtab of system,while numanodes is.
True, but it's the same bug, it needs to be spec['location'] rather than spec. I made the same mistake when I added location parsing, would be nice to fix two instances of the same bug in one patch.
— Reply to this email directly, view it on GitHub https://github.com/teemtee/tmt/pull/2924#issuecomment-2106854628, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFR23D4IPYEXGA7YJNTQGDZCBUGRAVCNFSM6AAAAABHTLQOMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWHA2TINRSHA . You are receiving this because you authored the thread.Message ID: @.***>