tmt icon indicating copy to clipboard operation
tmt copied to clipboard

Setup cleanup test with local scripts

Open adiosnb opened this issue 2 years ago • 6 comments

Related to #825

adiosnb avatar Apr 04 '23 08:04 adiosnb

Note: there are some similarities between setup/teardown tasks, and one type of extra checks, https://github.com/teemtee/tmt/discussions/1875#discussion-4899207 - there will be post-test checks for sure, some might be interested in performing something before the test as well. Points in which checks take effect will be very, very related to points in which cleanup/teardown tasks would play out.

happz avatar Jun 19 '23 18:06 happz

@adiosnb I'd like to add this PR for the 1.28 release - feel free to disagree :) https://github.com/teemtee/tmt/pull/2210 is about to be merged, and I'd like to work with you to amend both our changes to provide nice output, tracking and timeout honoring for both setup/cleanup, test check and the test itself. I have some ideas about using context managers for unified logging, but the rebase would be a PITA...

happz avatar Aug 31 '23 14:08 happz

ur changes to provide nice output, tracking and timeout honoring for both setup/cleanup, test check and the test itself. I have some ideas about using context managers for unified logging, but the rebase would be a PITA...

I found some time to do the rebase. In the end, I just dropped the previous implementation and did it once again.

Let's discuss the current implementation and the possible timeout tracking on the next tmt discussion.

adiosnb avatar Sep 08 '23 07:09 adiosnb

Going to resurrect this PR Soon(TM).

happz avatar Sep 12 '24 22:09 happz

Note: there are some similarities between setup/teardown tasks, and one type of extra checks, #1875 (comment) - there will be post-test checks for sure, some might be interested in performing something before the test as well. Points in which checks take effect will be very, very related to points in which cleanup/teardown tasks would play out.

Yes, exactly, to me it seems the before-test-check and after-test-check are very close to the setup/cleanup scenario.

psss avatar Sep 30 '25 06:09 psss

Going to resurrect this PR Soon(TM).

Triaging this PR along with others. Not sure about the state of this, but based on @happz comment I've put it as assigned it to him for the backburner. Let me know if you prefer to have these in the triage column instead or something else.

LecrisUT avatar Nov 11 '25 17:11 LecrisUT