Results 353 comments of Tee Ming

The example repo is different from the approach suggested by Rich. In the example repo, it's using a [dynamic import with a variable](https://vite.dev/guide/features.html#dynamic-import). This causes Vite to assume everything in...

These are the logs when it hangs (after upgrading everything to the latest). ```sh ❯ npm run test -- --run > [email protected] test > vitest --run RUN v2.1.3 /home/chewteeming/github/sveltekit-vitest-repro ✓...

I think this is the right behaviour since no SSR means no hydration, thus no repairing the DOM. It's easy enough to query the document for the loading element and...

> Isn't the Svelte app hydrated to the DOM regardless of whether SSR is enabled? Hydration is only required when the page contents have already been rendered by SSR. If...

You’ll have to change the build node version to 18.8 or higher since cloudflare’s default is lower. You can read how in the link below https://developers.cloudflare.com/pages/configuration/language-support-and-tools/#supported-languages-and-tools

I'm wondering if we should specify the node version for builds in .npmrc or the engines field in package.json (which doesn't work for cloudflare pages). This could become an issue...

> > [@benmccann](https://github.com/benmccann) could you add an .npmrc to always just use a higher node version when the cloudflare adapter is used? is there any case in which you would...

Isn't it already populated here? https://github.com/sveltejs/kit/blob/f67898d25ee32e9377221979d2a9e6b792786f4e/packages/adapter-vercel/files/edge.js#L13-L24 The ambient type for it exists too although it's not correctly included when importing the adapter at the moment. https://github.com/sveltejs/kit/blob/f67898d25ee32e9377221979d2a9e6b792786f4e/packages/adapter-vercel/ambient.d.ts#L1-L12 Or am I mistaken...

Thanks for this. Can you update the Cloudflare Workers adapter docs too?

Thank you! > Do you still think we should update the Cloudflare Workers docs since the two adapters have been merged? We could because it should be the exact same...