Mutify icon indicating copy to clipboard operation
Mutify copied to clipboard

Help translate Mutify.

Open teekamsuthar opened this issue 4 years ago • 6 comments

Although, translations to any language are welcomed. Here are the translations required as per user-base ordered by priority -

  • [ ] German (Germany)
  • [ ] Spanish (United States)
  • [ ] French (France)
  • [ ] Vietnamese (Vietnam)
  • [ ] German (Austria)
  • [ ] Spanish (Spain)
  • [ ] Spanish (Latin America)

Recommend tool for translation - Android Studio with translation helper plugin.

teekamsuthar avatar Jun 23 '21 14:06 teekamsuthar

Hi, Teekam Congratulations on building this helpful application. I would like to work on this. I have translated it to German(Germany) and Spanish (Spain) using google translate and working on Vietnamese and French. The dialog_positive_btn and open_spotifystring key have the same value Open Spotify should I change code to use only open_spotify?

gupta-shrinath avatar Oct 21 '21 07:10 gupta-shrinath

The source code in the master branch seems to be of the older version of the application. Maybe you have continued the development of the application in private. If the current version of the application doesn't support the languages mentioned in the PR you could merge it because it won't have any major breaking changes.

gupta-shrinath avatar Oct 26 '21 17:10 gupta-shrinath

Thanks for helping out with the current translations in Mutify @gupta-shrinath, I will be pushing out a new commit with updated strings soon, so please let me know if you will be able to help with translation of those as well. :)

teekamsuthar avatar Nov 01 '21 12:11 teekamsuthar

The dialog_positive_btn and open_spotifystring key have the same value Open Spotify should I change code to use only open_spotify?

Yes, please keep all the extra duplicate values, even if they're same. The id's are different so that these can be identified easily in code, also it helps with code readability. Thanks :)

teekamsuthar avatar Nov 01 '21 12:11 teekamsuthar

The dialog_positive_btn and open_spotifystring key have the same value Open Spotify should I change code to use only open_spotify?

Yes, please keep all the extra duplicate values, even if they're same. The id's are different so that these can be identified easily in code, also it helps with code readability. Thanks :)

Make sense. I thought of this and to be on the safer side created a new commit I'll just have to revert the commit in the PR.

Thanks for helping out with the current translations in Mutify @gupta-shrinath, I will be pushing out a new commit with updated strings soon, so please let me know if you will be able to help with translation of those as well. :)

Sure.

gupta-shrinath avatar Nov 01 '21 12:11 gupta-shrinath

Hi, @teekamsuthar I have reverted the commit which removes the key dialog_positive_btn.

gupta-shrinath avatar Nov 06 '21 07:11 gupta-shrinath