Ted Young
Ted Young
Thanks for the writeup @rochdev. We can devote some time to looking at this.
I would expect a tracer to always return a valid span context in the situations you describe. I only see the `null` case as relevant when you ask a tracer...
@tylerbenson can we close this since we are deprecating v0.30?
Now that we are moving on Trace Identifiers, we should consider adding unwrap as part of the same release. A couple thoughts: * We should probably move this to a...
@felixbarny I agree that "Thread safety" should be clarified. In this case, it should just mean "safety," in the sense that it exceptions will not occur, memory will not be...
We may want to consider unwrapping as part of the same RFC. Typecasting will no longer be reliable if OpenTracing middleware becomes common. ### Relevant Issues and PRs * https://github.com/opentracing/opentracing-java/issues/282...
I'm not sure if we want to have explicit categories (language, type, etc) and then some additional generic tags, or just tags. In other words: is metadata `key:value` like categories,...
yeah, in general this is great.. I might suggest that `registryType` just be a tag, so that everything is a tag. That give us flexibility (some projects may span multiple...
Why do we need a delegate for the GlobalTracer? Can we just ensure it's always initialized to a NoopTracer and avoid the delegation overhead? ``` import Tracer from './tracer'; const...
Only thing I can think of: the delegate would let you swap out the tracer reference later, in case you already stored the reference somewhere else before the tracer was...