tedli
tedli
`-DDO_NOT_USE_WMAIN=ON` can make `mingw` happy.
https://github.com/OpenAtomFoundation/pika/blob/bf3574dbc4d877ebaacc423b0a8261fabe4ff466/src/net/src/redis_conn.cc#L89-L112 89 行从网络 read 一次,得到 `nread`,112 行,把 `nread` 传给 redis parser。 https://github.com/OpenAtomFoundation/pika/blob/bf3574dbc4d877ebaacc423b0a8261fabe4ff466/src/net/src/redis_parser.cc#L313-L321 parser 里逻辑,会判断上一次 read,有没有读“一半”的,有剩的一半,给拼到本次读的前面,然后进行对 request 进行 parse(解 cmd) https://github.com/OpenAtomFoundation/pika/blob/bf3574dbc4d877ebaacc423b0a8261fabe4ff466/src/net/src/redis_parser.cc#L344-L346 可以看到解的过程是个循环,也就是说会把**读到的**可完整解出来的,都解出来,然后就是给 worker 现成执行了。 但是问题是**读到的**,比如 pipeline 里命令很多的话,或者网络 io 并发高等等因素,导致*一次* read 没有把所有...
还有一个点是 [go-redis](https://github.com/redis/go-redis) 的 pipeline 实现问题 https://github.com/redis/go-redis/blob/50f04c14dee344147e9cf061f752ee913fd6c3ee/redis.go#L497-L501 https://github.com/redis/go-redis/blob/50f04c14dee344147e9cf061f752ee913fd6c3ee/internal/proto/writer.go#L37-L53 https://github.com/redis/go-redis/blob/50f04c14dee344147e9cf061f752ee913fd6c3ee/command.go#L59-L61 可以看到,只是把 cmd 对象攒起来,然后循环 write 而已。 而看 redis 自己的 client pipeline 实现: https://github.com/redis/redis/blob/22a29935ff7a354b8d90c110040f5bd0ea80068e/deps/hiredis/hiredis.c#L1106-L1117 可以看到 redis 自己的 client 的 pipeline 实现,攒 cmd 的逻辑是在拼 buffer,`newbuf...
问题分 2 个维度,1 是 pipeline 本身维度,2 是并发读写状态维度。 1. pipeline 本身维度: 少部分用户反馈的小概率遇到 pipeline 出错问题。 原因是,redis 网络协议层面判断不出来是不是 pipeline,io 层面只是知道 read 到了若干 command。pika 成功解出来 command 就放 worker 线程里执行了,command 执行是并发的,会有几率导致 pipeline 里后执行的 command,先 response...
UPDATE: *incorrect*, for reference only ++++++++++++++++++++++++ Hi all, Thanks for reply. Hi @RainbowMango , I found how apiserver handle `/readyz` and `/healthz`: https://github.com/kubernetes/apiserver/blob/6e796557fa8a46ec48109166f6db572bbda87267/pkg/server/config.go#L363-L403 ~~It seems both readyz and healthz act...
Introducing a new `livenessProbe` liked field is good. (I used annotations, is because I'm sure it's a common scenario) I have a crude impl, already running for a week. My...
Hi all, FYI, We met the same problem. https://github.com/karmada-io/karmada/blob/7395a8bdf5e6ef934c49358b0536edbd0f794f34/pkg/util/resource.go#L52-L73 tried to make line `68` `lifted.IsScalarResourceName(rName)` happy, can fix this issue.
Hi @chaunceyjiang , I will be there until 3:00 PM, unfortunately after 3:00, there is another meeting that I have to attend.
https://github.com/karmada-io/karmada/pull/3812#issuecomment-1680128010 FYI
Hi @fuweid , If the proposal given in #8788 is acceptable, I'm glade to finish this pr. > -=Draft Code=- > Troubleshooting with proposal: > UID=$(kubectl get pods -n -o...