default-bookmark-folder icon indicating copy to clipboard operation
default-bookmark-folder copied to clipboard

selection is not retained

Open thosf opened this issue 5 years ago • 6 comments

This is a Question

Previously, using this add-on retained the selected default bookmark folder option. Now it does not and I have to select it every time I turn on the computer. why is this?

thosf avatar May 30 '19 10:05 thosf

Hello, and thank you for reporting this problem! It is definitely not the normal behavior- the setting should be saved and not change, even after a reboot. If that is possible, could you answer the questions below to help me figure out where the problem is. Thanks! 🙂

  • Could you confirm that you are referring to the option to change the default bookmark folder for the Firefox built-in bookmarking?
  • You say the setting value is not retained- does it come back to the default- No folder selected (use Firefox's default bookmark location)- or to something else after a reboot?
  • Do you remember when this issue started?
  • Which version of the add-on are you using?
  • Which edition of Firefox are you using? It could be Firefox (regular edition) / Developer Edition / Beta / Nightly / Other (please specify).
  • Which version of Firefox are you using?
  • Which language are you using with Firefox?
  • Which platform/OS are you using? It could be Windows / macOS / Linux / Other (please specify).
  • Which version of the platform/OS are you using?

Additionally, I do not know how familiar you are with Firefox profiles, but something you can try is creating a new clean profile, install the add-on and check if the problem is still present.

More information on profiles are available here:

teddy-gustiaux avatar May 31 '19 00:05 teddy-gustiaux

Thank you for your kind reply to my problem.  I have provided answers in-line with your questions (below). Hope this is helpful.Thomas Fredrick

Edit by maintainer to have responses formatted to be readable on GitHub:

  • Could you confirm that you are referring to the option to change the default bookmark folder for the Firefox built-in bookmarking? YES
  • You say the setting value is not retained- does it come back to the default- No folder selected (use Firefox's default bookmark location)- or to something else after a reboot? It returns to the default NO FOLDER SELECTED
  • Do you remember when this issue started? ABOUT SIX WEEKS AGO (seems like after an upgrade - either Firefox or Windows - sorry I don't remember which)
  • Which version of the add-on are you using? 2.10.0
  • Which edition of Firefox are you using? REGULAR EDITION
  • Which version of Firefox are you using? 67.0 (64-bit)
  • Which language are you using with Firefox? ENGLISH
  • Which platform/OS are you using? Microsoft Windows 10 Home
  • Which version of the platform/OS are you using? 10.0.17134 Build 17134

-------- Original Message -------- Subject: Re: [teddy-gustiaux/default-bookmark-folder] selection is not retained (#66) From: Teddy Gustiaux [email protected] Date: Thu, May 30, 2019 8:52 pm To: teddy-gustiaux/default-bookmark-folder [email protected] Cc: thosf [email protected], Author [email protected]

Hello, and thank you for reporting this problem! It is definitely not the normal behavior- the setting should be saved and not change, even after a reboot. If that is possible, could you answer the questions below to help me figure out where the problem is. Thanks! 🙂 Could you confirm that you are referring to the option to change the default bookmark folder for the Firefox built-in bookmarking? YES You say the setting value is not retained- does it come back to the default- No folder selected (use Firefox's default bookmark location)- or to something else after a reboot? It returns to the default NO FOLDER SELECTED Do you remember when this issue started? ABOUT SIX WEEKS AGO (seems like after an upgrade - either Firefox or Windows - sorry I don't remember which) Which version of the add-on are you using? 2.10.0 Which edition of Firefox are you using? It could be Firefox (regular edition) / Developer Edition / Beta / Nightly / Other (please specify). REGULAR EDITION Which version of Firefox are you using?  67.0 (64-bit) Which language are you using with Firefox? ENGLISH Which platform/OS are you using? It could be Windows / macOS / Linux / Other (please specify). Microsoft Windows 10 Home Which version of the platform/OS are you using?  10.0.17134 Build 17134 Additionally, I do not know how familiar you are with Firefox profiles, but something you can try is creating a new clean profile, install the add-on and check if the problem is still present. More information on profiles are available here: Profiles - Where Firefox stores your bookmarks, passwords and other user data Use the Profile Manager to create and remove Firefox profiles —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

thosf avatar Jun 01 '19 11:06 thosf

did you receive my reply?Was it helpful?  thomas...

-------- Original Message -------- Subject: Re: [teddy-gustiaux/default-bookmark-folder] selection is not retained (#66) From: Teddy Gustiaux [email protected] Date: Thu, May 30, 2019 8:52 pm To: teddy-gustiaux/default-bookmark-folder [email protected] Cc: thosf [email protected], Author [email protected]

Hello, and thank you for reporting this problem! It is definitely not the normal behavior- the setting should be saved and not change, even after a reboot. If that is possible, could you answer the questions below to help me figure out where the problem is. Thanks! 🙂 Could you confirm that you are referring to the option to change the default bookmark folder for the Firefox built-in bookmarking? You say the setting value is not retained- does it come back to the default- No folder selected (use Firefox's default bookmark location)- or to something else after a reboot? Do you remember when this issue started? Which version of the add-on are you using? Which edition of Firefox are you using? It could be Firefox (regular edition) / Developer Edition / Beta / Nightly / Other (please specify). Which version of Firefox are you using? Which language are you using with Firefox? Which platform/OS are you using? It could be Windows / macOS / Linux / Other (please specify). Which version of the platform/OS are you using? Additionally, I do not know how familiar you are with Firefox profiles, but something you can try is creating a new clean profile, install the add-on and check if the problem is still present. More information on profiles are available here: Profiles - Where Firefox stores your bookmarks, passwords and other user data Use the Profile Manager to create and remove Firefox profiles —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

thosf avatar Jun 17 '19 12:06 thosf

I also noticed that while the computer is on, and I close Firefox, when starting Firefox again, the default bookmark folder that I selected was lost. Hope this helps.

BTW: I now have Firefox Quantum 67.0.4 (64-bit) which produces this issue.

thosf avatar Jun 24 '19 10:06 thosf

Hello again, and thank you so much for your answers and for following up on this. 👍 I have been trying to reproduce the problem with an almost exact setup, and I was unfortunately unsuccessful. You seem to not be the only one affected, as you have seen for yourself in #68.

You did mention the problem started after an upgrade about six weeks ago, so there is a possibility that this issue is caused by the migration of the back-end storage for WebExtensions in Firefox 66 (more details here if you are interested).

Put simply, Firefox has started to use a new system to store the add-ons settings with Firefox 66. It was automatic and transparent for both the users and the add-on developers. However, like with any migration, there is always a chance of something going wrong.

I have mentioned Firefox profiles briefly previously. They are where Firefox stores your bookmarks, passwords and other user data. If you can create a new profile, and test the add-on to see if the problem still exists, that would be very helpful and would rule out a migration issue or a corrupted profile (which can sometimes happen). This link explains how to use the Profile Manager to create and remove Firefox profiles. Please let me know if you need any help in this regard.

That being said, if you are having the same problem with a clean Firefox profile, I do have a few other questions:

  • If you try to set other options, such as toggles (like Add new bookmarks to the top of the selected folder) or folder selection for the quick bookmark icon, are they retained or not?
  • If you set an option, and refresh the page, is the selection retained?

Thanks in advance for your help with this. 🙂

teddy-gustiaux avatar Jun 25 '19 01:06 teddy-gustiaux

I'm suddenly experiencing the same problem. I think it must have started in the last one or two weeks.

I use Firefox on two machines and the machines use Firefox Sync to synchronize bookmarks, settings and addons. Both machines also use exactly the same addons with the same settings and the same versions. Right now the relevant versions are 68.0.1 64-bit (German) for Firefox and 2.10.1 for your addon.

Only one of the machines shows the problem, the second one works as expected.

Concerning your questions I noticed the following:

  • The default folder settings are not retained at all. Even if I stay on the addons settings page and just refresh it, the default settings are restored.
  • But this is only true for the default folder settings. Other settings like "add to the top" are retained correctly after a refresh.
  • On the machine where the bug occurs, refreshing (or opening) the settings page shows an empty page (I need to click a button on the top to see any settings). But on the machine that works correctly the last shown settings page is retained and automatically shown.
  • On the machine with the bug the following error is logged to the Firefox console when you refresh the settings page: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. 4 ExtensionUtils.jsm

cremor avatar Aug 05 '19 11:08 cremor