default-bookmark-folder icon indicating copy to clipboard operation
default-bookmark-folder copied to clipboard

CPU spikes upon switching tabs even though the quick bookmark icon is disabled

Open FatOrangutan opened this issue 5 years ago • 1 comments

This is an Improvement Request

Which component or feature of the add-on is your improvement request related to? Please describe. On about:performance, I see Energy impact spikes for Default Bookmark Folder (DBF). This is probably due to the tab event listeners. But I have disabled the quick bookmark (QB) icon, so I expect these listeners to never be added.

Describe the improvement you would like I would like DBF with QB disabled to limit CPU use to when I click the (Firefox's built-in) star icon or press ctrl+D or use the Bookmark All Tabs feature.

Describe alternatives you have considered

Additional context If I edit manifest.json to remove the tabs permission, the spikes are much lower, the bookmark to last used folder works while the QB feature breaks, as expected.

FatOrangutan avatar May 16 '19 14:05 FatOrangutan

Thank you for providing all these details! I have not experienced CPU spikes myself, but I am more than happy to look into performance improvements for the add-on and more specifically the tab event listeners you mentioned. I have targeted it for the next minor version! 🙂

teddy-gustiaux avatar May 18 '19 01:05 teddy-gustiaux