default-bookmark-folder icon indicating copy to clipboard operation
default-bookmark-folder copied to clipboard

Restoring bookmarks from bookmarksxxx.json breaks places.sqlite

Open ghost opened this issue 3 years ago • 4 comments

This is a Bug Report

Description

Restoring bookmarks from bookmarksxxx.json breaks places.sqlite

Steps to reproduce the problem

  1. From Library, Import and Backup > Backup... to bookmarksxxx.json
  2. Exit Firefox then delete places.sqlite
  3. Open Firefox, restore bookmarks from bookmarksxxxx.json
  4. places.sqlite, once restored, is partially damaged (missing bookmarks and bookmarks folders)

Expected behavior

A correctly restored places.sqlite

Specifications

  • Version of the add-on: 3.0
  • Firefox edition: Firefox (regular edition)
  • Firefox version: 85.0
  • Firefox language: English
  • Platform/OS: Windows
  • Platform/OS version: 7 (x64)

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Never encountered the issue with Firefox <85 and Default Bookmark Folder < 3.0 For testing furthermore: I disabled Default Bookmark Folder 3.0, proceeded again to backup to .json file and restored places.sqlite correctly I re-enabled Default Bookmark Folder 3.0, proceeded again to backup to .json file and restored places.sqlite incorrectly again. EDIT: it appears that the Default Bookmark Folder 3.0 extension needs to be disabled only when restoring the bookmarks from bookmarks.xxxx.json file

ghost avatar Jan 26 '21 14:01 ghost

Importing an HTML file also seemed to be a disaster for one user: https://support.mozilla.org/questions/1323357

jscher2000 avatar Jan 27 '21 16:01 jscher2000

Similar here also: When importing .json bookmark from laptop to desktop computer, lots of bookmarks are out of their folder, plus dividers where added everywhere here and there, or folder where moved somewhere else, creating a complete mess. To solve this issue, I deleted the addon (Default Bookmark Folder) and re-import my bookmark again, and everything was perfect. I am using Firefox Extended Support Release version 78.7, on W10. Thank you .

Okaaayyyy avatar Jan 28 '21 19:01 Okaaayyyy

I guess we're all aware that rather than deleting the extension, disabling it is enough, then restore the .json backup (or the html backup). You can then re-enable the extension. No point in removing such a handy piece of work!

Cade66 avatar Jan 28 '21 19:01 Cade66

You're perfectly right. I'll wait until the problem is fix before reinstalling it. Yes it's a handy piece of work.

Okaaayyyy avatar Jan 29 '21 01:01 Okaaayyyy