tectonic icon indicating copy to clipboard operation
tectonic copied to clipboard

20240528 fix build for xetex layout

Open uncomfyhalomacro opened this issue 1 year ago • 2 comments

fixes #1190

uncomfyhalomacro avatar May 28 '24 03:05 uncomfyhalomacro

This causes multiple-definition errors on many targets - I understand why the swap to c++17, but why rename an internal function to use the harfbuzz naming scheme (which is causing the build errors)? If harfbuzz has a function that can do what we want directly, I'd imagine we should just use that, instead of trying to overlap it.

CraftSpider avatar Jun 24 '24 05:06 CraftSpider

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.94%. Comparing base (19654bf) to head (22492f6). Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
- Coverage   46.99%   46.94%   -0.06%     
==========================================
  Files         176      177       +1     
  Lines       65196    65190       -6     
==========================================
- Hits        30639    30602      -37     
- Misses      34557    34588      +31     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 29 '24 02:06 codecov[bot]