TCPDF icon indicating copy to clipboard operation
TCPDF copied to clipboard

fix: base64 images not rendered inside of html

Open compojoom opened this issue 1 year ago • 5 comments

I'm not sure when this happened, but default base64 encoded images were no longer rendered in html text.

If the image is rendered like this:

<img src="data:image/png;base64,....." />

the image was not rendered when inside of an html text. Instead one has to replace data:image/png;base64, with @which in my opinion is not ideal and an overhead.

https://github.com/tecnickcom/TCPDF/issues/179

compojoom avatar Dec 01 '23 19:12 compojoom

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 01 '23 19:12 CLAassistant

Please try to resolve the conflicts.

nicolaasuni avatar Apr 20 '24 17:04 nicolaasuni

@williamdes I rebased. Sorry for the changelog change, but it seems you had an empty space and my IDE wants to remove it :)

compojoom avatar Apr 22 '24 05:04 compojoom

@williamdes I rebased. Sorry for the changelog change, but it seems you had an empty space and my IDE wants to remove it :)

That's okay

But can you remove the other commits? git reset hard on the base and cherry pick https://github.com/tecnickcom/TCPDF/pull/671/commits/605d0a1ba75f54d9edc9d903213ae0f76b434a02 then force push?

williamdes avatar Apr 22 '24 05:04 williamdes

how about now?

compojoom avatar Apr 22 '24 06:04 compojoom