python-patch icon indicating copy to clipboard operation
python-patch copied to clipboard

line.strip('\r\n') contains '\r'.

Open rhinoceros opened this issue 6 years ago • 3 comments

line.strip('\r\n') contains '\r'.

rhinoceros avatar Jun 01 '19 11:06 rhinoceros

Can you describe the problem that your patch is fixing?

fmarier avatar Jun 29 '19 00:06 fmarier

Can you describe the problem that your patch is fixing?

when I parse svn diff , I meet the case: there were a lot of '\r' in line, and hunkactual["linestgt"] will always less than hunk.linestgt . hunk parse failed.

rhinoceros avatar Jun 29 '19 10:06 rhinoceros

@rhinoceros tests on Python 3 don't pass with this commit, so it is unlikely to be merged. Can you provide the diff file and describe how did it? If it came from public repo, that would be the best.

techtonik avatar Jan 01 '21 15:01 techtonik