simplebank icon indicating copy to clipboard operation
simplebank copied to clipboard

Corrected test get list accounts

Open leedrum opened this issue 1 year ago • 1 comments

  • Issue: the expectation of the test case does not match with the test in video
  • How to fix: Add condition OR to the SQL query

leedrum avatar Jun 21 '24 19:06 leedrum

This doesn't need to be corrected. The code evolved over time when new lectures are added. If you want to see the exact code as in the recorded video, you must look at the history: https://github.com/techschool/simplebank/commits/master/db/sqlc/account_test.go In the first commit, the code looks exactly as in the video.

techschool avatar Jun 22 '24 06:06 techschool

I do not agree with that test because we don't cover the pagination cases. btw, I think we can create another function to get a list account that doesn't depend on the owner. I will close this PR.

leedrum avatar Jul 16 '24 04:07 leedrum