leiningen icon indicating copy to clipboard operation
leiningen copied to clipboard

print newest deps

Open cdzwm opened this issue 2 years ago • 6 comments

When conflict deps found, print the depency of newest version.

cdzwm avatar Apr 21 '22 07:04 cdzwm

Thanks for this patch.

I think overall it's good to surface this information, but the way it's presented in this implementation is not particularly clear. Simply saying Suggest: ... is confusing because it's presented alongside the suggestion to use :exclusions and it's not obvious how the two different suggestions are related. I think this needs some more thought put into it, but we could include it if the information is presented in a less confusing way.

There's also a couple technical issues with it; for one it removes :eval-in :leiningen which is pretty important, so that needs to be changed.

Also it appears to bring in a new dependency, which causes a lot of extra work for downstream packagers. As far as I can tell, this is only being used for a single function, which duplicates logic already available from Aether: https://github.com/technomancy/leiningen/blob/master/leiningen-core/src/leiningen/core/pedantic.clj#L68 Let's use the existing implementation instead of bringing in something redundant.

technomancy avatar Apr 22 '22 16:04 technomancy

According to you suggestion, I make some modifications.

cdzwm avatar Apr 24 '22 07:04 cdzwm

Sorry, I haven't gotten a chance to look at this yet, but I don't think it needs to be closed. Was that intentional?

technomancy avatar May 02 '22 22:05 technomancy

II'd like to think about this modification again. I think there are still some problems, but you can also take a look at it first and suggest some changes.

cdzwm avatar May 02 '22 22:05 cdzwm

I will make some fixes.

cdzwm avatar May 17 '22 13:05 cdzwm

Fix is completed.

cdzwm avatar May 20 '22 05:05 cdzwm