leiningen icon indicating copy to clipboard operation
leiningen copied to clipboard

Make more useful / less risky recommendations when encountering version ranges

Open vemv opened this issue 5 years ago • 2 comments

Hi!

Say I place a dependency on [org.webjars.npm/github-com-bevacqua-dragula "3.7.2"].

Then the:pedantic? :ranges option will give me the following warning:

WARNING!!! version ranges found for:
[org.webjars.npm/github-com-bevacqua-dragula "3.7.2"] -> [org.webjars.npm/contra "[1.9.4,1.9.4]"]
Consider using [org.webjars.npm/github-com-bevacqua-dragula "3.7.2" :exclusions [org.webjars.npm/contra]].

That warning is inviting me to remove a transitive dependency altogether, therefore breaking the main functionality.

A more useful warning would be:

WARNING!!! version ranges found for:
[org.webjars.npm/github-com-bevacqua-dragula "3.7.2"] -> [org.webjars.npm/contra "[1.9.4,1.9.4]"]
Consider using [org.webjars.npm/github-com-bevacqua-dragula "3.7.2" :exclusions [org.webjars.npm/contra]],
along with adding an explicity dependency on org.webjars.npm/contra, at a fixed, known-good version.

WDYT?

Thanks - Victor

vemv avatar Aug 21 '18 02:08 vemv

Yes, that's better; happy to take a patch.

technomancy avatar Sep 20 '18 21:09 technomancy

Related to #1729.

glts avatar May 18 '19 16:05 glts