mui-downshift icon indicating copy to clipboard operation
mui-downshift copied to clipboard

Feature Request: Accept other css units on MenuHeigth prop

Open gsasouza opened this issue 5 years ago • 2 comments

Will be good if we can define MenuHeigth in differents css units. vh and vw for example will improve menu resposivity.

gsasouza avatar Aug 30 '18 15:08 gsasouza

@gsasouza This might be difficult currently with the use of react-virtualized as it needs explicit pixel units, although I've considered dropping the use of react-virtualized in the next major version (and re-releasing the current version as mui-virtualized-downshift or similar).

I did this for mui-table 2.0.0, and released 1.0.0 as mui-virtualized-table and documented some of the benefits here (mostly specific to a table, but related). I'm going to going create a new issue to discuss this change (but no timeline when this might be available).

techniq avatar Aug 31 '18 17:08 techniq

@gsasouza See this comment that might give you a sufficient workaround until (and if) #54 is implemented.

techniq avatar Sep 05 '18 13:09 techniq