Plexus-app icon indicating copy to clipboard operation
Plexus-app copied to clipboard

[Issue]: Detects microG on a deGoogled CalyxOS device

Open StellarSand opened this issue 11 months ago โ€ข 28 comments

Hi, after updating to 2.1.0 the issue is still present.

Originally posted by @CristianKerr in #46

TL;DR:

  • Device has deGoogled main profile
  • microG is installed in work profile
  • App detects the device as microG on main profile

My test results

@CristianKerr's test results

StellarSand avatar Jan 22 '25 01:01 StellarSand

@CristianKerr was v2.0.7 working fine for you?

StellarSand avatar Jan 22 '25 01:01 StellarSand

I think I never had 2.0.7, I first installed the day I reported/commented the issue an it was already not working. I am not sure which version was it.

CristianKerr avatar Jan 22 '25 09:01 CristianKerr

I just installed 2.0.7 and it is not working either.

CristianKerr avatar Jan 22 '25 09:01 CristianKerr

I'm pretty sure it's not an issue with the app (it could be, but I'm pretty sure it's not). Could you please check if microG is somehow present but disabled in the main profile?

StellarSand avatar Jan 22 '25 17:01 StellarSand

https://gitlab.com/CalyxOS/calyxos/-/issues/2972

Also, meant to send these replies: https://github.com/techlore/Plexus-app/issues/46#issuecomment-2608454149 here, not there

lucasmz-dev avatar Jan 22 '25 23:01 lucasmz-dev

Yeah so it's still installed but disabled and therefore it will always be detected by other apps.

StellarSand avatar Jan 23 '25 19:01 StellarSand

Could the check be changed to checked if it's disabled or not?

lucasmz-dev avatar Jan 23 '25 19:01 lucasmz-dev

@StellarSand sorry I am away I will look into the packages as soon as possible.

This is why I think there could be somewhere option to change this, maybe even a little bit hidden (or with a text "I solemnly swear..." if you are afraid people would misuse this. I think that some trust in the community would be fine, we are people who install custom roms I think nobody has an interest in malicious acting. (Please don't take me wrong, I respect your choice ๐Ÿ˜Š I am just trying to argument a little bit here.)

The issue is if I send my reports now, it will be misrepresented. And I so want to share my experience with the application ๐Ÿ˜Š

CristianKerr avatar Jan 23 '25 20:01 CristianKerr

Could the check be changed to checked if it's disabled or not?

Yes I can make an exception for CalyxOS and treat disabled microG as deGoogled, but I'll wait for someone from CalyxOS team to reply to your issue first. Based on their response I'll make further changes in the app.

This is why I think there could be somewhere option to change this, maybe even a little bit hidden (or with a text "I solemnly swear..." if you are afraid people would misuse this. I think that some trust in the community would be fine, we are people who install custom roms I think nobody has an interest in malicious acting.

The reason Iโ€™ve stuck with auto-detection is that it has worked well across all ROMs (with the occasional times where it was incorrectly detecting due to my code mistakes, but was fixed as they happened), and this specific case with CalyxOS is the first time something like this has popped up.

I agree that the community is trustworthy, and I value that, but I believe itโ€™s important to keep things as seamless, accurate & consistent as possible for everyone using the app. There could be other ways to handle this specific edge case (like treating disabled microG as deGoogled on CalyxOS), and Iโ€™m definitely open to exploring them. If I hit a point where thereโ€™s no better way to handle it, I will definitely consider adding an option to let users manually select the config.

StellarSand avatar Jan 24 '25 17:01 StellarSand

Iโ€™d appreciate your help in testing a theory. If both Plexus and APK Explorer & Editor are detecting microG in the main profile, itโ€™s possible that other apps might also detect it, unless they specifically filter out disabled apps (microG apps in this case).

Could you try testing a few apps you know have issues on degoogled devices but work well with microG? Iโ€™ll test them on an actual degoogled device, and you can test on CalyxOS. Then, we can compare our results.

StellarSand avatar Jan 27 '25 01:01 StellarSand

@StellarSand Ah yes, I am back, sorry forgot about it. Can you please tell me what exactly to do and check? Maybe write down your steps and I will copy them on my device.

I agree that the community is trustworthy, and I value that, but I believe itโ€™s important to keep things as seamless, accurate & consistent as possible for everyone using the app. There could...

I understand, thank you for explanation ๐Ÿ˜Š I hope we will manage to find good solution ๐Ÿ‘

CristianKerr avatar Jan 27 '25 08:01 CristianKerr

btw these are all my disabled packages:

package:com.google.android.gsf package:com.android.vending package:app.seamlessupdate.client package:com.google.android.gms package:com.android.messaging

(which you already probably expected, but I wanted to confirm)

CristianKerr avatar Jan 27 '25 08:01 CristianKerr

package:app.seamlessupdate.client

did you mean to disable the updater, you won't be getting updates

lucasmz-dev avatar Jan 27 '25 14:01 lucasmz-dev

I didn't change this (not manually). And I am actually getting updates. But what I have (and its probably that) is that I don't have them auto install/restart. I always have notification about a new update and I click on a button there when I want to apply/restart.

CristianKerr avatar Jan 27 '25 14:01 CristianKerr

It's really weird to me that it is disabled. This is the system updater and it isn't disabled on my install.

You should be able to enable automatic restarts on Settings > System > System updates > Automatic restart

lucasmz-dev avatar Jan 27 '25 14:01 lucasmz-dev

But I don't want that, I want to have a control over when I apply the update. I did set it in that menu. What I wanted to say is that I didn't change it via adb.

CristianKerr avatar Jan 27 '25 14:01 CristianKerr

That's fine, but still it shouldn't be disabled. I just tested and it's possible to disable it without ADB, anyway, it seems that disabling it hides that menu with those options.

lucasmz-dev avatar Jan 27 '25 15:01 lucasmz-dev

@lucasmz-dev any news on this? Could you maybe include a workaround, maybe sone action hidden in settings if you are worried people would misuse it? And people can find about it from the issue. Or maybe if user tries to switch in ui you can show popup that would ask if they are sure... Maybe you can limit the option for calyxos users since you know it doesn't happen anywhere else? Thank you ๐Ÿ˜Š

CristianKerr avatar Mar 18 '25 13:03 CristianKerr

@CristianKerr that's more for stellar to decide, the bug I reported it seems like they're looking into it but it's a bit unclear what the plan is on the Calyx side, I can't quite tell Apparently completely hiding microG would cause some apps that would work not to

lucasmz-dev avatar Mar 18 '25 15:03 lucasmz-dev

I see, got it, thank you. @StellarSand what do you think? ๐Ÿ˜Š

CristianKerr avatar Mar 18 '25 21:03 CristianKerr

Note: if you go in each microG component and manually Hide them, Plexus considers the device degoogled. I did notice that in the rollout of Android Auto, Calyx decided to go with hiding the app instead of the regular disable which seems nice. It seems that's what they're talking about in the issue.

It does leave a bit of a hole though, like on devices like the no longer supported Pixel 3s, shiftphone 6, etc. I'm also unsure what happens to people who had microG disabled beforehand, are they gonna migrate that, or...? I guess we'll have to wait and see

lucasmz-dev avatar Mar 25 '25 02:03 lucasmz-dev

@lucasmz-dev what do you mean by hiding them? If I go to apps, I don't see any microG component there to be hidden. Or is it something that has to be done with adb? Thank you

CristianKerr avatar Mar 31 '25 09:03 CristianKerr

It's complicated if you can't open their app info page in settings, but apps in CalyxOS can be hidden which is similar to disabling, and you do it on the app info page

lucasmz-dev avatar Mar 31 '25 09:03 lucasmz-dev

What name of the apps am I looking for? "micro"(G) or "goog"(le) found nothing, I show all apps including the system apps:

Image

Image

Thank you

CristianKerr avatar Mar 31 '25 11:03 CristianKerr

Unfortunately when you have a profile with microG disabled on the SetupWizard, they aren't shown.

lucasmz-dev avatar Mar 31 '25 18:03 lucasmz-dev

Aha, ok, thank you.

CristianKerr avatar Mar 31 '25 19:03 CristianKerr

I'll make an exception for CalyxOS & treat disabled microG as deGoogled. I have been preoccupied with some stuff of my own, so I'll resume development by the end of this month.

StellarSand avatar Apr 01 '25 19:04 StellarSand

Hi @StellarSand, that is a good news, thank you! And thanks in general for working on such an amazing app ๐Ÿ˜Š

CristianKerr avatar Apr 02 '25 08:04 CristianKerr

Please test this APK and let me know if the issue is fixed now.

StellarSand avatar May 03 '25 19:05 StellarSand

Just tried on another profile and it seems to result in it still thinking it has microG

lucasmz-dev avatar May 03 '25 20:05 lucasmz-dev