zxcvbn-elixir icon indicating copy to clipboard operation
zxcvbn-elixir copied to clipboard

Make parts of codebase more elixir'y

Open techgaun opened this issue 6 years ago • 2 comments

There are parts of codes that would benefit from more Elixir style coding. This issue will serve as a ground for future PRs and commits for improving codebase quality

techgaun avatar Mar 22 '19 02:03 techgaun

Did you have any parts in mind?

axelson avatar Mar 31 '19 19:03 axelson

@axelson ya like https://github.com/techgaun/zxcvbn-elixir/blob/master/lib/zxcvbn/matching.ex#L358-L494 https://github.com/techgaun/zxcvbn-elixir/blob/master/lib/zxcvbn/scoring.ex#L142-L169

There're few places where I got anonymous functions within function body. I would prefer to extract them out to their own functions. Also, this one: https://github.com/techgaun/zxcvbn-elixir/issues/7 would be good to work on

Also, input from community would be good as feedback so this can get better in general

techgaun avatar Mar 31 '19 22:03 techgaun