tech.ml.dataset icon indicating copy to clipboard operation
tech.ml.dataset copied to clipboard

`print-all` metadata lost by `filter-column`

Open harold opened this issue 1 year ago • 2 comments

Is this expected?

user> (ds/print-all (ds/->dataset {:a (range 100)}))
_unnamed [100 1]:

| :a |
|---:|
|  0 |
|  1 |
|  2 |
|  3 |
|  4 |
|  5 |
|  6 |
|  7 |
|  8 |
|  9 |
| 10 |
| 11 |
| 12 |
| 13 |
| 14 |
| 15 |
| 16 |
| 17 |
| 18 |
| 19 |
| 20 |
| 21 |
| 22 |
| 23 |
| 24 |
| 25 |
| 26 |
| 27 |
| 28 |
| 29 |
| 30 |
| 31 |
| 32 |
| 33 |
| 34 |
| 35 |
| 36 |
| 37 |
| 38 |
| 39 |
| 40 |
| 41 |
| 42 |
| 43 |
| 44 |
| 45 |
| 46 |
| 47 |
| 48 |
| 49 |
| 50 |
| 51 |
| 52 |
| 53 |
| 54 |
| 55 |
| 56 |
| 57 |
| 58 |
| 59 |
| 60 |
| 61 |
| 62 |
| 63 |
| 64 |
| 65 |
| 66 |
| 67 |
| 68 |
| 69 |
| 70 |
| 71 |
| 72 |
| 73 |
| 74 |
| 75 |
| 76 |
| 77 |
| 78 |
| 79 |
| 80 |
| 81 |
| 82 |
| 83 |
| 84 |
| 85 |
| 86 |
| 87 |
| 88 |
| 89 |
| 90 |
| 91 |
| 92 |
| 93 |
| 94 |
| 95 |
| 96 |
| 97 |
| 98 |
| 99 |
user> (-> (ds/print-all (ds/->dataset {:a (range 100)}))
          (ds/filter-column :a #(< % 90)))
_unnamed [90 1]:

|  :a |
|----:|
|   0 |
|   1 |
|   2 |
|   3 |
|   4 |
|   5 |
|   6 |
|   7 |
|   8 |
|   9 |
| ... |
|  79 |
|  80 |
|  81 |
|  82 |
|  83 |
|  84 |
|  85 |
|  86 |
|  87 |
|  88 |
|  89 |

After filter-column it no longer 'prints all'.

harold avatar Sep 28 '23 16:09 harold

I don't think it is expected - I think this is a legit issue.

cnuernber avatar Sep 29 '23 13:09 cnuernber

I guess in clojure this is a common thing, have to consider explicitly preserving metadata (?), not a huge deal, obviously, I can just call print-all again later if need be.

harold avatar Sep 29 '23 15:09 harold