Leaflet.pattern icon indicating copy to clipboard operation
Leaflet.pattern copied to clipboard

Build with latest source to prevent deprecation warnings

Open kaliatech opened this issue 3 years ago • 2 comments

I understand this is a no longer supported package, however, this might be helpful to others still using this package. In #23 the source was updated to prevent deprecation warnings (thank you!), however, the dist packages were not updated

This PR builds the files in /dist with that latest source. In order to do so using newer tools, I had to update to a newer jake. So, I then went ahead updated all dependencies to latest. As part of that, I had to make a minor tweak to the UglifyJS config.

Changes:

  • Newer dependencies
  • Modified package version specifier to require leaflet-1.0.0 or newer. (Probably not required in hindsight).
  • Modified uglifyjs config to remove a no longer supported option.
  • Updates the version in package.json to 0.1.1 in case this ever gets pushed to NPM registry.

Note that running jake test results in an error, likely due to the significant jake version changes. I did not debug.

kaliatech avatar Jun 27 '22 21:06 kaliatech

Thanks for sharing this ; we are facing a "double-bundling" of leaflet (https://github.com/etalab/transport-site/issues/3376) and it looks like this PR could solve it!

Poke @teastman if you are still around and willing to merge / release package!

thbar avatar Aug 08 '23 12:08 thbar

Looking forward to the release, @teastman. This PR will be a great addition!

thomaslrg avatar Aug 29 '24 14:08 thomaslrg