now-playing icon indicating copy to clipboard operation
now-playing copied to clipboard

Rewrite in TypeScript

Open paced opened this issue 3 years ago • 5 comments

Please explain the problem/why you would want to see a change and any workarounds you might have in place.

I don't want to maintain a JavaScript application when TypeScript exists. I'm going to prioritise a change to using TypeScript instead of JavaScript alongside Electron.

This should be good for contributors as well.

On another note, if I'm going to maintain this application, I need a thorough understanding of how the old app works. This will allow me to have that familiarity.

paced avatar May 25 '21 08:05 paced

Working on this currently. Will be part of the v0.8.0 release. This requires a pretty big rewrite:

  • Add back the renderer to the web view.

paced avatar May 25 '21 17:05 paced

I need to be more careful: perhaps leave the renderer JS file as JavaScript and change everything else?

paced avatar May 26 '21 06:05 paced

I could rewrite much of the code as using the custom protocol and handling those signals.

paced avatar Sep 27 '21 03:09 paced

Moving refactoring tickets to v0.12.0.

paced avatar Oct 05 '21 23:10 paced

This is going well so far: entire main thread code has been rewritten in TypeScript along with a few other tickets I was working on at the same time.

This dramatically reduces the amount of code and I think it makes it much easier to read and contribute to as well. It should be a good change provided I can convince people to update to v0.11.0.

paced avatar Jun 19 '22 09:06 paced