btcmap.org icon indicating copy to clipboard operation
btcmap.org copied to clipboard

eslint warnings

Open dadofsambonzuki opened this issue 7 months ago • 6 comments

There are hundreds of eslint warnings throughout the project.

A thankless task, but some hero should address them.

dadofsambonzuki avatar May 08 '25 07:05 dadofsambonzuki

Status update (after #240 is merged):

✖ 213 problems (0 errors, 213 warnings)

These are coming from the left over rules. A good start would be to tackle the rule 'svelte/require-each-key': 'warn',

Steps:

  • comment rule out here
  • run yarn lint
  • fix the svelte loops one by one while testing if each view/component is still working as expected

Let us know if you need any help or you have any questions regarding this task

escapedcat avatar May 12 '25 04:05 escapedcat

Anyone working this yet? If not, I can start working through them as I learn the code base.

kwilson62 avatar May 28 '25 02:05 kwilson62

@kwilson62 go ahead, let us know if you get stuck

escapedcat avatar May 28 '25 03:05 escapedcat

Update after #257

Before:

✖ 194 problems (0 errors, 194 warnings)

After:

✖ 127 problems (0 errors, 127 warnings)

escapedcat avatar May 31 '25 09:05 escapedcat

Example on how to fix (some?) @typescript-eslint/no-unused-expressions warnings.

Via: https://github.com/sveltejs/eslint-plugin-svelte/issues/934#issuecomment-2543128219

escapedcat avatar May 31 '25 09:05 escapedcat

Further fixing examples

(AI helped)

escapedcat avatar May 31 '25 09:05 escapedcat