DMS-Backend icon indicating copy to clipboard operation
DMS-Backend copied to clipboard

merge: (#492) 자습실 수정 API분리

Open tedsoftj1123 opened this issue 2 years ago • 4 comments

작업 내용 설명

  • [x] 자습실 수정 api분리

주요 변경 사항

  • UpdateStudyRoom

결과물

체크리스트

  • [x] 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • [ ] 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • [ ] 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

  • resolved #492

tedsoftj1123 avatar May 14 '23 23:05 tedsoftj1123

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 14 '23 23:05 sonarqubecloud[bot]

Codecov Report

Merging #497 (2a8c06e) into develop (daba4b5) will increase coverage by 0.01%. The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #497      +/-   ##
============================================
+ Coverage       1.73%   1.74%   +0.01%     
  Complexity        46      46              
============================================
  Files            530     525       -5     
  Lines           6339    6294      -45     
  Branches         139     138       -1     
============================================
  Hits             110     110              
+ Misses          6227    6182      -45     
  Partials           2       2              
Impacted Files Coverage Δ
...dms/domain/studyroom/dto/UpdateStudyRoomRequest.kt 0.00% <0.00%> (ø)
...omain/studyroom/dto/UpdateStudyRoomSeatsRequest.kt 0.00% <0.00%> (ø)
...in/studyroom/dto/UpdateStudyRoomTimeSlotRequest.kt 0.00% <0.00%> (ø)
...domain/studyroom/usecase/CreateStudyRoomUseCase.kt 0.00% <ø> (ø)
...n/studyroom/usecase/UpdateStudyRoomSeatsUseCase.kt 0.00% <0.00%> (ø)
...tudyroom/usecase/UpdateStudyRoomTimeSlotUseCase.kt 0.00% <0.00%> (ø)
...domain/studyroom/usecase/UpdateStudyRoomUseCase.kt 0.00% <ø> (ø)
...tlin/team/aliens/dms/domain/auth/AuthWebAdapter.kt 0.00% <ø> (ø)
...aliens/dms/domain/studyroom/StudyRoomWebAdapter.kt 0.00% <0.00%> (ø)
...in/studyroom/dto/UpdateStudyRoomSeatsWebRequest.kt 0.00% <0.00%> (ø)
... and 2 more

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daba4b5...2a8c06e. Read the comment docs.

codecov[bot] avatar May 14 '23 23:05 codecov[bot]

아직 기존 api를 삭제하면 안될 것 같아요. 이것도 draft 해놓고 프론트 리팩토링 + 부여 UI 개선 작업 끝나면 적용하는거 어떨까여

rlaisqls avatar May 15 '23 00:05 rlaisqls

tedsoftj1123 avatar May 15 '23 10:05 tedsoftj1123