cyan icon indicating copy to clipboard operation
cyan copied to clipboard

Ensure tests run on windows

Open euclidianAce opened this issue 4 years ago • 4 comments

Additionally, find some way to run CI for windows as leafo's github actions do not support it. So either fix that upstream or find a different method.

  • maybe use chocolatey - luarocks package is pretty outdated, we use the 3.0 format so that wouldn't work
  • manually install everything - would work, but I'd have to learn what windows-latest comes with on github actions. for example can I curl/wget a luarocks binary? and add it to the PATH
  • See if there's another github action that supports windows

euclidianAce avatar Apr 07 '21 07:04 euclidianAce

I have made a futile attempt to patch leafo's github action to support windows. It fetches and builds Lua perfectly fine, the issue seems to be with adding it to the path. I have no idea what the trouble is, luajit seems to work fine but it makes a symlink somewhere instead/in addition to adding to PATH. So I have no idea

euclidianAce avatar Apr 09 '21 09:04 euclidianAce

I think I'll push this back to the 0.2 milestone as I've used cyan on windows a little bit and it seems to work for the most part. I'd like to focus on a little bit of polish for the first release. CI can be worried about after that.

If anybody knows of a good github action to use, I'm all ears. Otherwise my tentative plan is to maybe write a custom action for hererocks

euclidianAce avatar May 03 '21 18:05 euclidianAce

I'm also curious about this! I have just converted the LuaRocks CI from Travis CI to Github Actions — just for Linux and Mac, though; Windows still runs on Appveyor. So If anyone finds a way to run Github Actions for Lua stuff on Windows cleanly, I'm also interested! Tackling this is not a priority for me now since Appveyor is working fine, but it would be nice to simplify things.

hishamhm avatar Feb 23 '22 11:02 hishamhm

@euclidianAce Keep an eye on https://github.com/leafo/gh-actions-luarocks/pull/14 :)

hishamhm avatar Jul 29 '22 03:07 hishamhm