TeacherFund_next icon indicating copy to clipboard operation
TeacherFund_next copied to clipboard

Create different size images

Open stripedpajamas opened this issue 5 years ago • 16 comments

Currently our images are too big. The header image we're using is 4mb. Loading on mobile is slow.

Acceptance criteria:

  • There are small, medium, and large versions of each image
  • All images are compressed to the highest amount that does not affect human-eye quality
  • Which size image is loaded is based on the screen size of the website user

In the near future, there may be different images for different screen sizes (not just different image sizes), but this is a good step to take in the interim.

stripedpajamas avatar Jun 20 '19 20:06 stripedpajamas

Would like to work on this issue.

devarora07 avatar Aug 03 '19 13:08 devarora07

Hey there,

If this issue is still available, I'd like to give it a crack!

Best, Richard

RichardViskovic avatar Sep 09 '19 07:09 RichardViskovic

Absolutely @RichardViskovic it's all yours!

joelwass avatar Sep 09 '19 16:09 joelwass

I submitted a pull request #116 for this issue! I'm still new to the whole open source contribution thing so hopefully I did it correctly. Let me know!

EricNewcombe avatar Oct 03 '19 21:10 EricNewcombe

would like to work on this

sukanyashet avatar Oct 01 '20 11:10 sukanyashet

Is this issue still open? I would like to work on this issue...

shubham-sharma-2323 avatar Nov 22 '21 13:11 shubham-sharma-2323

Yes @shubham-sharma-2323 it is still open if you would like to do it!

joelwass avatar Nov 23 '21 00:11 joelwass

comments in this closed PR may help @shubham-sharma-2323 https://github.com/teacherfund/TeacherFund_next/pull/116

joelwass avatar Nov 23 '21 00:11 joelwass

I would like to work on this if it is still open.

swingleSara avatar May 17 '22 23:05 swingleSara

It is @swingleSara please refer to the closed PR #116 and it's comments

joelwass avatar May 17 '22 23:05 joelwass

I don't know how I missed that in all the comments before mine, but I clearly see it now. Thanks!

On Tue, May 17, 2022, 17:13 Joel Wasserman @.***> wrote:

It is @swingleSara https://github.com/swingleSara please refer to the closed PR #116 https://github.com/teacherfund/TeacherFund_next/pull/116 and it's comments

— Reply to this email directly, view it on GitHub https://github.com/teacherfund/TeacherFund_next/issues/99#issuecomment-1129406926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXFON6YQIPWX7IRCQVRJB5DVKQRZ7ANCNFSM4HZ4QJNQ . You are receiving this because you were mentioned.Message ID: @.***>

swingleSara avatar May 18 '22 21:05 swingleSara

Hello, I'd like to take up this issue as my Hacktoberfest contribution!

adityapathakk avatar Oct 04 '22 17:10 adityapathakk

Is this issue will be tagged as Hactoberfest ?

0xClint avatar Oct 08 '22 16:10 0xClint

This issue is listed on Upforgrabs.net, but it sounds like it's been closed?

Tyler-Pritchard avatar Oct 12 '22 19:10 Tyler-Pritchard

I want to work on this issue, it still alive?

abdulhaseeb036 avatar Oct 25 '22 07:10 abdulhaseeb036

Yes it is, it's not closed, please refer to previous comments and PR #116 for details on how to approach this

joelwass avatar Oct 25 '22 17:10 joelwass

Hello. I would like to work on this issue.

KelvingomeX avatar Apr 12 '23 20:04 KelvingomeX

Hi! I submitted #250 pull request to address this. I believe I handled the index page images. I was going to work on the other images but, I noticed since the last pull request related to this issue, it looks like you are using a new Image component. I am not sure if this component supports tags or not.

jmurphy1196 avatar Jun 18 '23 06:06 jmurphy1196

fixed in #250

joelwass avatar Jun 20 '23 18:06 joelwass