teable icon indicating copy to clipboard operation
teable copied to clipboard

Enhance Image Preview

Open AliceLanniste opened this issue 1 year ago • 12 comments

close #767

tasks:

  • [x] zoom in/out
  • [x] rotate
  • [x] reset
  • [x] drag

AliceLanniste avatar Oct 01 '24 12:10 AliceLanniste

@boris-w , I created a zoom in/out icon component, but it won't display in imagePreview. I don't know how to solve this problem and I don't understand the feature of image dragging, can you give me some help?

AliceLanniste avatar Oct 10 '24 07:10 AliceLanniste

@boris-w , I created a zoom in/out icon component, but it won't display in imagePreview. I don't know how to solve this problem and I don't understand the feature of image dragging, can you give me some help?

Do you mean the imported icons don't show up?

boris-w avatar Oct 11 '24 10:10 boris-w

Our icons are maintained on figma and synchronized to icons packages via scripts, give me a moment to think about how to collaborate on icon changes!

boris-w avatar Oct 11 '24 10:10 boris-w

Our icons are maintained on figma and synchronized to icons packages via scripts, give me a moment to think about how to collaborate on icon changes!

my icon components are copied from iconfont,so it doesn't show successful. I want to complete the pr, it is necessary to implement icon components

AliceLanniste avatar Oct 16 '24 13:10 AliceLanniste

Today I'll update the icons you need to the develop branch, you just need to merge the develop.

boris-w avatar Oct 17 '24 02:10 boris-w

Related: https://github.com/teableio/teable/pull/996

boris-w avatar Oct 17 '24 04:10 boris-w

Today I'll update the icons you need to the develop branch, you just need to merge the develop.

thanks, could you add a reset icon component? , It's necessary to reset image for users

AliceLanniste avatar Oct 18 '24 02:10 AliceLanniste

Today I'll update the icons you need to the develop branch, you just need to merge the develop.

thanks, could you add a reset icon component? , It's necessary to reset image for users

Reset -> RefreshCcw

boris-w avatar Oct 18 '24 03:10 boris-w

@boris-w ,could you explain about dragging ? I don't understand the functionality

AliceLanniste avatar Oct 23 '24 04:10 AliceLanniste

@boris-w ,could you explain about dragging ? I don't understand the functionality

Dragging is considered for situations when the image is enlarged beyond the current screen size, requiring the ability to drag in order to view parts of the image that extend beyond the screen.

boris-w avatar Oct 23 '24 04:10 boris-w

@boris-w hello, I completed the pr ,can you review it?

AliceLanniste avatar Oct 28 '24 13:10 AliceLanniste

It looks like you had a problem with the merge, a lot more unnecessary changes were made.

boris-w avatar Oct 29 '24 02:10 boris-w